Your message dated Sun, 4 Nov 2007 15:23:20 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#398625: adapted patch against current dpkg has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: dpkg-dev Version: 1.13.24 Severity: wishlist Tags: patch The `dpkg-buildpackage -B' should call `debian/rules build-arch'. The current behaviour is calling `build' target, so the builddaemons compiles the arch-indep staff. I.e. the z88dk package has build-arch target which compiles arch specific binaries with gcc and build-indep target which shouldn't be called by buildd. Just now, the builders compiles unecessary files. The proposed patch: --- dpkg-buildpackage.orig 2006-10-13 15:40:33.000000000 +0200 +++ dpkg-buildpackage 2006-11-14 17:36:47.000000000 +0100 @@ -71,6 +71,7 @@ checkbuilddep=true checkbuilddep_args='' binarytarget=binary +buildtarget=build sourcestyle='' changesversion='' since='' @@ -111,7 +112,7 @@ -nc) noclean=true; if [ -z "$binaryonly" ]; then binaryonly=-b; fi ;; -b) binaryonly=-b; [ "$sourceonly" ] && \ { echo >&2 "$progname: cannot combine $1 and -S" ; exit 2 ; } ;; - -B) binaryonly=-B; checkbuilddep_args=-B; binarytarget=binary-arch; [ "$sourceonly" ] && \ + -B) binaryonly=-B; checkbuilddep_args=-B; buildtarget=build-arch; binarytarget=binary-arch; [ "$sourceonly" ] && \ { echo >&2 "$progname: cannot combine $1 and -S" ; exit 2 ; } ;; -S) sourceonly=-S; checkbuilddep=false; [ "$binaryonly" ] && \ { echo >&2 "$progname: cannot combine $binaryonly and $1" ; exit 2 ; } ;; @@ -214,7 +215,16 @@ cd ..; withecho dpkg-source $passopts $diffignore $tarignore -b "$dirn"; cd "$dirn" fi if [ x$sourceonly = x ]; then - withecho debian/rules build + status=0 + if [ x$buildtarget != xbuild ]; then + set +e + withecho debian/rules $buildtarget + status=$? + set -e + fi + if [ x$buildtarget = xbuild ] || [ $status = 2 ]; then + withecho debian/rules build + fi withecho $rootcommand debian/rules $binarytarget fi if [ "$usepause" = "true" ] && \
--- End Message ---
--- Begin Message ---Simon Richter writes ("Bug#398625: adapted patch against current dpkg"): > I have written a new implementation of the patch proposed earlier, > against the current shell script. As discussed on debian-devel, I think this approach is fundamentally wrong. Failure of a rules target should not be treated as an invitation to try a different target. The package should declare (eg with Build-Options) what the situation is. The appropriate approach is still being discussed, but I don't think it is correct at this stage for us to be thinking about writing implementations in dpkg-buildpackage. Please go back to the mailing lists and try to get something resembling rough consensus on a better approach. In the meantime I don't think this bug represents any desirable or intended change to dpkg, so I'm going to close it. Thanks, Ian.
--- End Message ---
