This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch master
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=5c9ff51023b54ab56c5f0a8e141b707ac75ed99d

commit 5c9ff51023b54ab56c5f0a8e141b707ac75ed99d
Author: Guillem Jover <guil...@debian.org>
AuthorDate: Sat Oct 13 13:11:38 2018 +0200

    test: Add descriptions for the shellcheck exclude codes
    
    Having to refer to the documentation to know what these are about is
    annoying, inline a brief description.
---
 debian/changelog |  1 +
 t/shellcheck.t   | 10 +++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 36fb657ba..d6bdf353d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -140,6 +140,7 @@ dpkg (1.19.3) UNRELEASED; urgency=medium
     - Add superficial autopkgtest functional tests.
   * Test suite:
     - Add new shellcheck author test.
+    - Add descriptions for the shellcheck exclude codes.
 
   [ Updated programs translations ]
   * German (Sven Joachim).
diff --git a/t/shellcheck.t b/t/shellcheck.t
index e067345bc..0eb64bd05 100644
--- a/t/shellcheck.t
+++ b/t/shellcheck.t
@@ -40,11 +40,11 @@ my @files = qw(
     debian/dpkg.postrm
     scripts/dpkg-maintscript-helper.sh
 );
-my @shellcheck_opts = (qw(
-    --exclude=SC2039
-    --exclude=SC2166
-    --exclude=SC2034
-));
+my @shellcheck_opts = (
+    '--exclude=SC2039', # Allow local keyword.
+    '--exclude=SC2166', # Allow -a and -o.
+    '--exclude=SC2034', # Allow unused variables for colors.
+);
 
 plan tests => scalar @files;
 

-- 
Dpkg.Org's dpkg

Reply via email to