Please find, for review, the debconf templates and packages descriptions for the miniupnpd source package.
This review will last from Thursday, August 22, 2013 to Sunday, September 01,
2013.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
Preamble: I'm not entirely happy with this review. I feel like the
whole debconf templates do no look very idiomatic but I found no way
to give them less French accent..:-)
--- miniupnpd.old/debian/miniupnpd.templates 2013-08-17 07:53:13.557776725
+0200
+++ miniupnpd/debian/miniupnpd.templates 2013-08-22 09:29:43.789726277
+0200
@@ -2,24 +2,24 @@
Type: boolean
Default: false
_Description: Start the MiniUPnP daemon?
- Select if the MiniUPnP daemon should started automatically at boot time.
+ Please choose this option if you want to automatically start the MiniUPnP
daemon at boot time.
Our usual formula...
Template: miniupnpd/listen
Type: string
-_Description: IP address to listen for UPnP queries on your LAN:
- The MiniUPnP daemon will listen for requests on your local network. Please
+_Description: IP address to listen for UPnP queries on the local network:
+ The MiniUPnP daemon will listen for requests on the local network. Please
enter the IP address it should listen on.
Just avoid possessive articles.You know the rationale: "that might
not be "my" network.
Template: miniupnpd/iface
Type: string
_Description: External WAN network interface where to open ports:
- The MiniUPnP daemon will listen on a specific IP address on your LAN, then it
- will open ports on your WAN interface. Enter the name of your WAN network
+ The MiniUPnP daemon will listen on a specific IP address on the local
network, then it
+ will open ports on the WAN interface. Enter the name of the WAN network
interface on which the MiniUPnP daemon will do the port forwarding.
Ditto.
Template: miniupnpd/ip6script
Type: boolean
Default: false
-_Description: Enable ip6tables script?
- Uppon startup of the MiniUPnP daemon, the init script can initialize the
- MiniUPnP IPv6 firewall chain.
+_Description: Enable IPv6 firewall chain?
+ Please specify whether the MiniUPnP daemon should run its
+ ip6tables script on startup to initialize the IPv6 firewall chain.
--- miniupnpd.old/debian/control 2013-08-17 07:53:13.557776725 +0200
+++ miniupnpd/debian/control 2013-08-22 09:30:39.255328099 +0200
Already proposed by Justin, previously
@@ -13,10 +13,10 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, debconf, iptables, iproute,
uuid-runtime, net-tools
Description: daemon providing UPnP Internet Gateway Device (IGD) services
MiniUPnPd is a small daemon providing UPnP Internet Gateway Device (IGD)
- services to your network. UPnP and NAT-PMP are used to improve internet
+ services to the network. UPnP and NAT-PMP are used to improve Internet
connectivity for devices behind a NAT router. Any peer to peer network
application such as games, IM, etc. can benefit from a NAT router supporting
- UPnP and/or NAT-PMP. For example the latest generation Microsoft XBOX 360 and
+ UPnP and/or NAT-PMP. For example, the latest generation Microsoft XBOX 360 and
Sony Playstation 3 game machines use UPnP commands to enable the online play
with the XBOX Live service and the Playstation Network. It has been reported
that MiniUPnPd is correctly working with the two consoles.
Just some details asthe description seems fine to me.
Maybe explain somewhere what UPnP means?
--
Template: miniupnpd/start_daemon Type: boolean Default: false _Description: Start the MiniUPnP daemon? Please choose this option if you want to automatically start the MiniUPnP daemon at boot time. Template: miniupnpd/listen Type: string _Description: IP address to listen for UPnP queries on the local network: The MiniUPnP daemon will listen for requests on the local network. Please enter the IP address it should listen on. Template: miniupnpd/iface Type: string _Description: External WAN network interface where to open ports: The MiniUPnP daemon will listen on a specific IP address on the local network, then it will open ports on the WAN interface. Enter the name of the WAN network interface on which the MiniUPnP daemon will do the port forwarding. Template: miniupnpd/ip6script Type: boolean Default: false _Description: Enable IPv6 firewall chain? Please specify whether the MiniUPnP daemon should run its ip6tables script on startup to initialize the IPv6 firewall chain.
--- miniupnpd.old/debian/miniupnpd.templates 2013-08-17 07:53:13.557776725
+0200
+++ miniupnpd/debian/miniupnpd.templates 2013-08-22 09:29:43.789726277
+0200
@@ -2,24 +2,24 @@
Type: boolean
Default: false
_Description: Start the MiniUPnP daemon?
- Select if the MiniUPnP daemon should started automatically at boot time.
+ Please choose this option if you want to automatically start the MiniUPnP
daemon at boot time.
Template: miniupnpd/listen
Type: string
-_Description: IP address to listen for UPnP queries on your LAN:
- The MiniUPnP daemon will listen for requests on your local network. Please
+_Description: IP address to listen for UPnP queries on the local network:
+ The MiniUPnP daemon will listen for requests on the local network. Please
enter the IP address it should listen on.
Template: miniupnpd/iface
Type: string
_Description: External WAN network interface where to open ports:
- The MiniUPnP daemon will listen on a specific IP address on your LAN, then it
- will open ports on your WAN interface. Enter the name of your WAN network
+ The MiniUPnP daemon will listen on a specific IP address on the local
network, then it
+ will open ports on the WAN interface. Enter the name of the WAN network
interface on which the MiniUPnP daemon will do the port forwarding.
Template: miniupnpd/ip6script
Type: boolean
Default: false
-_Description: Enable ip6tables script?
- Uppon startup of the MiniUPnP daemon, the init script can initialize the
- MiniUPnP IPv6 firewall chain.
+_Description: Enable IPv6 firewall chain?
+ Please specify whether the MiniUPnP daemon should run its
+ ip6tables script on startup to initialize the IPv6 firewall chain.
--- miniupnpd.old/debian/control 2013-08-17 07:53:13.557776725 +0200
+++ miniupnpd/debian/control 2013-08-22 09:30:39.255328099 +0200
@@ -13,10 +13,10 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, debconf, iptables, iproute,
uuid-runtime, net-tools
Description: daemon providing UPnP Internet Gateway Device (IGD) services
MiniUPnPd is a small daemon providing UPnP Internet Gateway Device (IGD)
- services to your network. UPnP and NAT-PMP are used to improve internet
+ services to the network. UPnP and NAT-PMP are used to improve Internet
connectivity for devices behind a NAT router. Any peer to peer network
application such as games, IM, etc. can benefit from a NAT router supporting
- UPnP and/or NAT-PMP. For example the latest generation Microsoft XBOX 360 and
+ UPnP and/or NAT-PMP. For example, the latest generation Microsoft XBOX 360 and
Sony Playstation 3 game machines use UPnP commands to enable the online play
with the XBOX Live service and the Playstation Network. It has been reported
that MiniUPnPd is correctly working with the two consoles.
Source: miniupnpd Section: net Priority: optional Maintainer: Thomas Goirand <z...@debian.org> Build-Depends: debhelper (>= 9), iptables-dev, po-debconf, libnfnetlink-dev Standards-Version: 3.9.4 Homepage: http://miniupnp.free.fr/ Vcs-Browser: http://anonscm.debian.org/gitweb/?p=users/zigo/miniupnpd.git Vcs-Git: http://anonscm.debian.org/git/users/zigo/miniupnpd.git Package: miniupnpd Architecture: any Depends: ${misc:Depends}, ${shlibs:Depends}, debconf, iptables, iproute, uuid-runtime, net-tools Description: daemon providing UPnP Internet Gateway Device (IGD) services MiniUPnPd is a small daemon providing UPnP Internet Gateway Device (IGD) services to the network. UPnP and NAT-PMP are used to improve Internet connectivity for devices behind a NAT router. Any peer to peer network application such as games, IM, etc. can benefit from a NAT router supporting UPnP and/or NAT-PMP. For example, the latest generation Microsoft XBOX 360 and Sony Playstation 3 game machines use UPnP commands to enable the online play with the XBOX Live service and the Playstation Network. It has been reported that MiniUPnPd is correctly working with the two consoles.
signature.asc
Description: Digital signature
