Hi Fernando, Am Tue, Aug 25, 2026 at 05:13:24PM +0200 schrieb Fernando Hueso González: > > However, I see more than just CMakeLists.txt files in > > I have removed some more unnecessary things, but the changes in the .cpp / > .h are strictly needed because CMake defines some preprocessor variables > that need to be checked in the .h and .cpp files.
Thank you for the clarification. > > I wonder whether you might want to split this into logical chunks. > In principle, I did not want to diverge from the original PR structure by > Kitware: https://github.com/MeVisLab/pythonqt/pull/345, once that one is > approved/merged we can get rid of the patch at once, rather than in multiple > steps. Ahhh, OK, I forgot that bit of information that you took over some existing patch. This explains why proper DEP3 fields are so important! Please add Origin: https://github.com/MeVisLab/pythonqt/pull/345 which would help a lot to understand the patch. BTW, you unintentionally commited a change of the upstream source since you probably forgot `quilt pop -a` before `git commit`. This happens from time to time to everyone. ;-) Just a hint to verify this for the future. Another commit I reverted was the probably unintended change of your email address in d/changelog. Please make sure it is identically to the address in the Uploaders field of d/control. If you run lintian on your build result it considers your work a NMU if its not identically. This is how I spotted the issue. > > I bet there is a CMake option / configuration for this. I'm not a CMake > > expert but I'm sure I have seen this and you can find it in > > codesearch.debian.net. > By using auto_configure as you suggested, it's automatically solved I > believe, no need to customize the CMake flags. Hmmm, sounds convincing in principle but I'm not observing this in my build. Can you please check again? > > You need to set the configure file in > > > > https://urldefense.com/v3/__https://salsa.debian.org/python-team/packages/pythonqt/-/settings/ci_cd*js-general-pipeline-settings__;Iw!!D9dNQwwGXtA!U8DKKz6tnQsHuDT5wvLoUU67jZtGP8q50deQwCKYMoQ1nDEBpzUaiQUwl5NHDjzTZuWizEHgsxcPpOBWEalB$ > > It was formerly set to > > recipes/debian.yml@salsa-ci-team/pipeline > > so your change was not used. > > Gotcha, thanks for the fix. You are welcome. This the MoM-idea: You learn when actual problems occure. ;-) > CI is green now. Let me know if you think more changes are needed. It would be great if I could reproduce the Multiarch install which is not visible in my pbuilder-build. BTW, I'm in contact with Mechtilde from DFSG team about the ctk package. She told me there is a licensing issue we need to discuss. We'll meet here at MiniDebConf Winterthur face to face later today. Kind regards Andreas. -- https://fam-tille.de
