Control: tags -1 moreinfo
On Sun, 2 Oct 2022 18:02:38 +0000 <luzip...@posteo.de> wrote:
Control: tags -1 -moreinfo
> d/copyright
> ===========
>
> Some GPL-2+ licensed files have the following additional exception:
> # The developers of the Exaile media player hereby grant permission
> # for non-GPL compatible GStreamer and Exaile plugins to be used and
> # distributed together with GStreamer and Exaile. This permission is
> # above and beyond the permissions granted by the GPL license by which
> # Exaile is covered. If you modify this code, you may extend this
> # exception to your version of the code, but you are not obligated to
> # do so. If you do not wish to do so, delete this exception statement
> # from your version.
I reworked the copyright file based on
https://sources.debian.org/src/exaile/3.4.0.2-1/debian/copyright/
Is the extension represented correct?
No. Please check the copyright format description for the "with" keyword.
Also, please try to present the copyright info in a more consice way. When two file groups have the same copyright
holders please merge them (combining the years to a year enumeration or year range).
You can also use broader wildcards in Files: and override parts of the matches
with a later Files: match.
I have already given you a hint that
"plugins/ipconsole/ipython_view.py by IBM Corporation is licensed under another
variant of the BSD-3-Clause."
So, please do not use Michael Bostock's version for that file match but add a
BSD-3-clause-IBM variant.
You should also remove his copyright line from the License: section because
that is already in the Copyright: section.
> d/rules
> =======
>
> Please remove or explain the lines:
>
> dh_auto_clean
> make manpage
> make completion
> ...
> #override_dh_installdocs:
> # dh_installdocs readme
> override_dh_usrlocal:
>
> Please think of a different method instead of calling dh_auto_clean
during install time to get rid of __pycache__ if
> that is the reason for it. Maybe just copy the Makefile line '-find .
-name "__pycache__" -exec rm -rf {} \;' ?
The point was to remove __pychache__.
Now I prevent dh_auto_build to do `make compile`
You have not explained "override_dh_usrlocal:".