Hi Phil, > The package looks good to me and I thank you for your work and enthusiasm for > the package. That sounds nice. Thank you for taking your time to review it.
> Let us give it a couple of days for other input/feedback and after this give > to > Daniel for sponsorship. Good with you? Sure, I'm fine with that schedule. Daichi Fukui On Mon, 17 Jun 2024 at 06:29, Phil Wyett <philip.wy...@kathenas.org> wrote: > > On Sun, 2024-06-16 at 16:08 +0900, Daichi Fukui wrote: > > Hi Phil, Daniel, Bas, and Tobias > > > > Thank you for taking time for this discussion and your advice for > > improvement. > > > > Daniel, > > > Daichi, I'd be happy to sponsor this upload in principle (once it passes > > > review) but only if you're interested in taking care of blktrace going > > > forward. > > Yes, I'm interested in taking care of blktrace and have a plan to > > address a different issue, that is #1069862. > > I appreciate it if you could sponsor this upload. > > > > Phil, > > > Firstly, apologies Daichi, if you wish adopt this package and maintain it > > > moving > > > forward, like Daniel, I would be happy to assist and support you as > > > needed if > > > requested. > > Yes, I would like to adopt the blktrace package and hopefully get > > assistance for that if you don't mind. > > In addition, I've updated the draft package as follows, following your > > review for improvement. > > For further details, please visit the following URL: > > https://mentors.debian.net/package/blktrace/ > > Alternatively, you can also download the package with 'dget' like: > > dget -x > > https://mentors.debian.net/debian/pool/main/b/blktrace/blktrace_1.3.0-0.1.dsc > > > > > - Edit line '* Update standards version to 4.6.0, no changes needed.' and > > > change > > > to '4.7.0' to match 'debian/control'. > > I've added '* Update standards version to 4.7.0, no changes needed.' > > to my section of the changelog. > > > > > - Edit line '* New upstream version 1.3.0' and now close bug #1073161 > > > that I > > > filed asking for the update to version 1.3.0. > > "(Closes: #1073161)" is now added to the changelog. > > > > > - Maybe be more verbose on what was updated in 'debian/copyright'. > > d/copyright was updated to show more precise copyright information, so > > I'ved added that description to the changelog. > > > > Hope this update is satisfactory and you, Daniel, or other developers > > help me upload and update this package. > > > > Daichi Fukui > > > > On Sat, 15 Jun 2024 at 11:41, Phil Wyett <philip.wy...@kathenas.org> wrote: > > > Hi all, > > > > > > I will do a short review in hope Daichi still has interest in the package. > > > > > > * Package build: Good. > > > * Lintian: Good. > > > * Install: Good. > > > * Licenses: > > > > > > philwyett@ks-windu:~/Development/builder/debian/mentoring/blktrace-1.3.0$ > > > lrc > > > en: Versions: recon 1.10.1 check 3.3.9-1 > > > > > > Parsing Source Tree .... > > > Reading copyright .... > > > Running licensecheck .... > > > > > > d/copyright | licensecheck > > > > > > GPL-2+ | GPL btrace.spec > > > > > > Nothing to really worry about here. For exactness it could be added to > > > 'debian/copyright' at a later date, but lets not be picky. :-) > > > > > > * Debian files: > > > > > > 'debian/changelog': > > > > > > - Edit line '* Update standards version to 4.6.0, no changes needed.' and > > > change > > > to '4.7.0' to match 'debian/control'. > > > > > > - Edit line '* New upstream version 1.3.0' and now close bug #1073161 > > > that I > > > filed asking for the update to version 1.3.0. > > > > > > - Maybe be more verbose on what was updated in 'debian/copyright'. > > > > > > Regards > > > > > > Phil > > > > > > -- > > > > > > Website: https://kathenas.org > > > > > > Instagram: https://instagram.com/kathenasorg/ > > > > > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg > > Hi Daichi, > > Sorry for the delayed response. I am a motor racing fan and the glorious 24 > hours of Le Mans has more than distracted me. :-D > > The package looks good to me and I thank you for your work and enthusiasm for > the package. > > Let us give it a couple of days for other input/feedback and after this give > to > Daniel for sponsorship. Good with you? > > Regards > > Phil > > -- > > Website: https://kathenas.org > > Instagram: https://instagram.com/kathenasorg/ > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
