Control: tags -1 + moreinfo

Hi Manuel,

Preamble...

Thanks for taking time to create this package and your contribution to Debian.

The below review is for assistance. It is offered to help submitters of
packages to Debian mentors improve their packages prior to possible
sponsorship into Debian. There is no obligation on behalf of the subitter to
make any alterations based upon information provided in the review.

Review...

1. Build: Good

2. Lintian: Issue

E: baby: unstripped-binary-or-object [usr/bin/baby]
N: 
N:   The package installs an unstripped binary or object file.
N:   
N:   Please note, that shared libraries have to be stripped with the
N:   --strip-unneeded option.
N: 
N:   Please refer to Binaries (Section 10.1) in the Debian Policy Manual and
N:   Libraries (Section 10.2) in the Debian Policy Manual for details.
N: 
N:   Visibility: error
N:   Show-Always: no
N:   Check: binaries/debug-symbols

W: baby source: debian-watch-could-verify-download 
debian/upstream/signing-key.asc [debian/watch]
N: 
N:   One or more upstream signing keys are present in the Debian package but
N:   are not being used.
N:   
N:   Please enable the cryptographic verification of downloads with the
N:   "pgpsigurlmangle" option in your watch file or remove the key.
N: 
N:   Please refer to the uscan(1) manual page for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/watch

3. Licenses: Issue

'debian/copyright' needs a 'Files: debian/*' section.

4. Build Twice (sudo pbuilder build --twice <package>.dsc): Fail

 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: verifying ./baby_1.0.34.orig.tar.gz.asc
dpkg-source: info: building baby using existing ./baby_1.0.34.orig.tar.gz
dpkg-source: info: building baby using existing ./baby_1.0.34.orig.tar.gz.asc
dpkg-source: info: local changes detected, the modified files are:
 baby-1.0.34/baby.conf
 baby-1.0.34/go.mod
dpkg-source: info: Hint: make sure the version in debian/changelog matches the 
unpacked source tree
dpkg-source: info: you can integrate the local changes with dpkg-source --commit
dpkg-source: error: aborting due to unexpected upstream changes, see 
/tmp/baby_1.0.34-1.diff.Odpz8r
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package
I: unmounting dev/ptmx filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: cleaning the build env 
I: removing directory /var/cache/pbuilder/build/634437 and its subdirectories

5. Reproducible builds (reporotest)[1]: Not performed due to (4. Build Twice)

6. Install (No previous installs): Not performed due to (4. Build Twice)

7. Upgrade (Over previous installs if any): N/A

Summary...

I believe 'baby' is not yet ready for sponsorship/upload. Could the contributor 
rectify one of more
of the rasied issues. Once updated to your satisfaction and a new upload done, 
please remove the
'moreinfo' on the Request For Sponsorship (RFS) bug report.

[1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

Regards

Phil

-- 

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to