On 1/29/26 9:07 AM, Santiago Vila wrote:
On Thu, Jan 29, 2026 at 08:48:21PM +0500, Andrey Rakhmatullin wrote:
On Thu, Jan 29, 2026 at 08:24:46AM -0700, Antonio Russo wrote:
I uploaded dante 1.4.4+dfsg-1 recently, but upstream ships a
bunch of extra files, both duplicates, and machine-generated
files. Many of these are removed by `make clean`.
This breaks the "build-twice" requirement.
How?
I'm also curious...
1. Upstream has some source code (maybe in a repository, maybe
not; I'm unaware of a public repository).
2. dh_auto_clean somehow does things like:
a. Removes the VERSION file
b. Creates symlinks inside the source tree
Presumably this is caused by the `make clean` target.
3. Upstream releases a tarball. This tarball includes a
VERSION file, and some autotools files. The symlinks (2b)
are resolved (i.e., there are duplicate files inside the
tarball). Maybe those are also in the upstream repo, maybe
not.
4. We build it. This includes patching some of the files in
the source tree, including the resolved symlinks of 2b.
5. dh_auto_clean removes VERSION and creates symlinks.
6. Things have been changed in the source tree. There might
be other things.
I'll be pushing out an RFS sometime in the next week-ish, so
they'll be something more concrete to look at, and I'll also
welcome your feedback then.
Joost has helpfully suggested that this might be some clean
vs. distclean issue. Perhaps a better solution is to also
patch the Makefile. In any case, I think removing any build
artifacts and unused components is good hygiene. I'm open to
opposing viewpoints, though!
Best,
Antonio
