* Jonathan McCrohan <jmccro...@gmail.com>, 2012-06-02, 17:42:
Shouldn't it be s/lt/lt-nl/?
What difference does it make? Surely if the package was not previously installed, the grep match would fail, making the rest of the postinst no-op.

Well, the line could have been added by user, in which case we shouldn't touch it. (Admittedly that's not very likely scenario...)

But using lt has benefits too: if the user removed old nyancat-server, then installing the new one would clean after the buggy postrm.

I'll leave the decision to you.

I would add -x/--line-regexp to the fgrep call.

Wouldn't it be nice if the postinst also take care of the case when the user enabled the service?

--
Jakub Wilk



--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120602172329.ga1...@jwilk.net

Reply via email to