On Wed, Nov 14, 2012 at 12:58 PM, Markus Koschany wrote:
> Changes since the last upload:
>
> * New Maintainer. (Closes: #544922)
> * Eat the Whistle will be maintained in a Git repository from now
> on. Change the Vcs-fields in debian/control accordingly.
> * debian/patches:
> Add 0005-Change-conf-and-replay-path.patch.
> Save and load configuration and replays in $HOME/.etw/ instead of
> /usr/share/games/etw and stop failing silently. (Closes: #693244)
Hi,
I've just reviewed this, and it looks mostly good. I did notice
things like the following:
+ FILE *f;
++ char path[1024];
++ sprintf(path, "%s/%s", getenv("HOME"), ".etw/etw.cfg" );
+ D(bug("Reading configuration...\n"/*-*/));
Note that a hardcoded 1024 isn't very portable. C defines PATH_MAX
for this purpose. Please use that instead.
Thanks,
Mike
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/CANTw=MPGyNE3Rg83TA4_vBC0ndmALU0a6JzMbB0=49p3eef...@mail.gmail.com
