On Wed, Nov 18, 2015 at 12:58 AM, Stefan Ahlers wrote: > I am looking for a sponsor for my package "liblastfm"
I don't intend to sponsor this package, but here is a review: There don't appear to be any blockers. These things would be nice to fix: Please put DEP-3 a header on the patch. http://dep.debian.net/deps/dep3/ I wonder what upstream has to say about the patch since it breaks compatibility with them. README.md contains build/install instructions, which are not useful to binary package users. I would strip that out with sed during the build process or ask upstream to move it to README.install. Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata When I set DPKG_GENSYMBOLS_CHECK_LEVEL=4, the build fails because there are many more symbols exported than present in the symbols files. The package FTBFS when built twice in a row, the second build fails because the build/ dir isn't removed by `debian/rules clean`. Automatic checks: build src/Xspf.cpp:118:5: warning: 'void lastfm::Xspf::expired()' is deprecated [-Wdeprecated-declarations] src/Xspf.cpp:118:13: warning: 'void lastfm::Xspf::expired()' is deprecated [-Wdeprecated-declarations] build/qt4/so/src/moc_RadioTuner.cpp:67:35: warning: 'void lastfm::RadioTuner::onXspfExpired()' is deprecated [-Wdeprecated-declarations] build/qt4/so/src/moc_Xspf.cpp:52:29: warning: 'void lastfm::Xspf::expired()' is deprecated [-Wdeprecated-declarations] build/qt4/so/src/moc_Xspf.cpp:53:31: warning: 'void lastfm::Xspf::onExpired()' is deprecated [-Wdeprecated-declarations] lintian P: liblastfm source: debian-control-has-unusual-field-spacing line 106 I: liblastfm source: duplicate-short-description liblastfm-dev liblastfm5-dev I: liblastfm source: duplicate-short-description liblastfm1 liblastfm5-1 I: liblastfm source: duplicate-short-description liblastfm-fingerprint1 liblastfm-fingerprint5-1 I: liblastfm source: duplicate-long-description liblastfm-fingerprint1 liblastfm-fingerprint5-1 I: liblastfm source: duplicate-short-description liblastfm-dbg liblastfm5-dbg P: liblastfm source: debian-watch-may-check-gpg-signature P: liblastfm-dbg: no-upstream-changelog P: liblastfm-fingerprint1: no-upstream-changelog P: liblastfm-fingerprint5-1: no-upstream-changelog P: liblastfm5-dev: no-upstream-changelog X: liblastfm5-dev: package-contains-broken-symlink usr/lib/x86_64-linux-gnu/liblastfm_fingerprint5.so liblastfm_fingerprint5.so.1 I: liblastfm5-1: hardening-no-fortify-functions usr/lib/x86_64-linux-gnu/liblastfm5.so.1.0.9 P: liblastfm5-1: no-upstream-changelog I: liblastfm5-1: no-symbols-control-file usr/lib/x86_64-linux-gnu/liblastfm5.so.1.0.9 I: liblastfm1: hardening-no-fortify-functions usr/lib/x86_64-linux-gnu/liblastfm.so.1.0.9 P: liblastfm1: no-upstream-changelog P: liblastfm-dev: no-upstream-changelog P: liblastfm5-dbg: no-upstream-changelog check-all-the-things $ codespell --quiet-level=3 <lots> $ flawfinder -Q -c . <lots> $ grep -riE 'fixme|todo|hack|xxx' . <lots> -- bye, pabs https://wiki.debian.org/PaulWise