On Mon, Aug 21, 2017 at 05:22:12PM -0700, Sean Whitton wrote: > Commenting on Charles' patch, I think that it would be clearer to have > the 'should' and 'must' requirements in separate sentences.
Good idea. > diff --git a/policy/ch-source.rst b/policy/ch-source.rst > index f706a13..89b355a 100644 > --- a/policy/ch-source.rst > +++ b/policy/ch-source.rst > @@ -99,10 +99,11 @@ later reconfigure the package without losing the changes > you made. > Debian changelog: ``debian/changelog`` > -------------------------------------- > > -Changes in the Debian version of the package should be briefly explained > -in the Debian changelog file ``debian/changelog``. [#]_ This includes > -modifications made in the Debian package compared to the upstream one as > -well as other changes and updates to the package. [#]_ > +Every source package must include the Debian changelog file, > +``debian/changelog``. Changes in the Debian version of the package > +should be briefly explained in this file. [#]_ This includes > +modifications made in the Debian package compared to the upstream one > +as well as other changes and updates to the package. [#]_ > > The format of the ``debian/changelog`` allows the package building tools > to discover which version of the package is being built and find out LGTM, seconded. That said, I'd expect the upgrade-checklist to say that this change is about clarifying that debian/copyright must exist (where before it was "fine" not existing). -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature