hi Aeliton, I took a look at the audio-visualizer-python package, up for sponsorship in the Python team. Don't worry about the volume of comments, all of it is quite easy to fix.
* repo: pristine-tar branch is missing. Forgot to 'gbp push'? * repo: please don't tag a Debian revision without an upload; for sponsored uploads within the team, the sponsor will typically take care of this. * repo: but do enable the CI on salsa. It's a powerful quality control tool for yourself and sponsors alike. You always want to inspect results for key parts (build, lintian, autopkgtest), even if those checks passed. * changelog: a new package should only have a single revision, closing an ITP bug (and no other entries). For subsequent updates, there should be a single new revision documenting every change to the packaging directory. * control: no human maintainer, which is required by Debian policy; you want to add yourself as an uploader. * control: outdated standards-version; redundant Rules-Requires-Root and Priority fields once you update that to 4.7.3. * control: VCS links commented out (and pointing to a non-team repo). * control: architecture set to "any" for what appears to be a pure-Python, architecture-independent util. Did you mean "all"? * control: no ffmpeg dependency on the binary pkg? * lintian: I: audio-visualizer-python: synopsis-is-a-sentence. An effective way to come up with a short description is to complete the following:>> Package-name is a <this part is your short description>. * copyright: please format the MIT license text into the customary paragraphs. * copyright: careful with setting a different, more restrictive license on debian/*: this may make forwarding patches difficult or impossible. Recommended practice is to match the upstream license. * tests: package is missing a non-trivial autopkgtest, even though it would be easy to add via the Testsuite field in d/control. Then for the package's design: audio-visualizer-python is an application written in Python that internally takes the shape of a (private) module [1], but it installs into /usr/lib/python3/ as a public module [2]. Unless the avp module is actually intended to be imported by other scripts, it should be installed as a private module. Pybuild accepts arguments via d/rules that tell it where to install libraries and scripts, examples in the team repo or via [3]. [1]https://www.debian.org/doc/packaging-manuals/python-policy/#programs-shipping-private-modules [2]https://www.debian.org/doc/packaging-manuals/python-policy/#types-of-python-modules [3]https://codesearch.debian.net/search?q=path%3Adebian%2Frules+PYBUILD_INSTALL_ARGS.*--install-lib.*--install-scripts&literal=0 Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail.
pgpPwfkjtb700.pgp
Description: OpenPGP digital signature
