On Thu, 2026-01-15 at 18:36 +0000, Jeroen Ploemen wrote: > > * tests: package is missing a non-trivial autopkgtest, even though it > would be easy to add via the Testsuite field in d/control. > > > Then for the package's design: audio-visualizer-python is an > application written in Python that internally takes the shape of a > (private) module [1], but it installs into /usr/lib/python3/ as a > public module [2]. Unless the avp module is actually intended to be > imported by other scripts, it should be installed as a private > module. > Pybuild accepts arguments via d/rules that tell it where to install > libraries and scripts, examples in the team repo or via [3]. > > Once the above comments have been addressed, simply re-add the > package to the IRC channel topic and/or ping me by e-mail.
Hi Jeroen, Thank you for your comments, I've addressed most of them except these two quoted above. I'll start with the last point first. I've added the line: export PYBUILD_INSTALL_ARGS=--install-lib=/usr/share/audio-visualizer- python/ --install-scripts=/usr/share/audio-visualizer-python/ to d/rules with no visible effect (after installing the .deb, dpkg -L still shows the avp python module at /usr/lib/python3/dist- packages/avp/). I had a look at [1] and I'm assuming that might be due to the lack of a file with '#!/usr/bin/python3' on the first line, as the section 5.1 of [1] says. If this is not it, I don't have an idea of what could be the issue here. I've also added python3 as a dependency as the section 5.2 says. ** About the Tests ** For the autopkgtests, would the idea be to run the program on a audio file (like the one in the tests/data/test.ogg) generating a video and check if the output video size 'is close to' something, or if we can extract frames from the generated video? 1. https://www.debian.org/doc/packaging-manuals/python-policy/index.html#document-python-programs
