Hi Jeroen, Thanks a lot for looking into this.
I addressed the comments and pushed the changes.
* watch: kept the existing git fix. My new commit is based on the remote
commit that fixed debian/watch.
* CI: removed debian/salsa-ci.yml, since CI is not enabled for the Salsa
project.
* rules: DEB_CARGO_CRATE now derives from DEB_VERSION_UPSTREAM instead of
hardcoding 0.6.12.
* rules: converted the dh_auto_configure and dh_auto_clean overrides to
execute_before_dh_auto_configure and execute_before_dh_auto_clean.
* patches: removed the Cargo.lock deletion patch and listed Cargo.lock in
debian/clean instead.
* tests: updated the autopkgtest to run from $AUTOPKGTEST_TMP and loop over
all supported Python versions via py3versions.
QA:
* sbuild -d unstable succeeded on amd64.
* lintian --display-info --pedantic on the generated .changes passed cleanly.
* The explicit autopkgtest import test passed in an unstable unshare testbed.
autopkgtest exits 8 because the available tests are superficial only; the
summary is: import PASS (superficial).
Cheers
Mike
Michele Cane, PhD
On Friday, 24 July 2026 at 13:17, Jeroen Ploemen <[email protected]> wrote:
> hi Michele,
>
> I took a look at the python-vtracer package, up for sponsorship in
> the Python team:
>
> * watch: broken, mixed v4 and v5 syntax (already fixed in git).
>
> * CI: d/salsa-ci.yml exists but the CI isn't enabled on salsa.
>
> * rules: 'export DEB_CARGO_CRATE=vtracer_0.6.12' but pkg is at
> v0.6.15; you probably don't want to hardcode the version there.
> * rules: both overrides could use execute_before.
>
> * patches: please don't delete files via patches. Doing so is
> inefficient and noisy, with large diffs every time the deleted file
> has any minor change. Just list the relevant file(s) in d/clean
> instead.
>
> * tests: when writing autopkgtests in Python packages, you want to
> loop over all supported Python versions, and *not* run things from
> the extracted source directory (use the provided empty directory in
> $AUTOPKGTEST_TMP instead). Plenty of examples at [1].
>
>
> Given the changes needed and lack of time on my end, I stopped
> reviewing at this point, so I can't say anything with regards to the
> binary pkg yet. Once the above comments have been addressed, simply
> re-add the package to the IRC channel topic and/or ping me by e-mail.
>
>
> [1]https://codesearch.debian.net/search?q=path%3Adebian%2Ftests%2F%20(py3versions%20-s)&literal=1&perpkg=1
>
publickey - [email protected] - 0xC017295D.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature
