hi Mike, I took a look at the python-pyvips package, up for sponsorship in the Python team:
* changelog/control: mr. Modaresi is still listed as uploader, but no
longer active as a Debian maintainer.
* control: missing Built-Using: ${sphinxdoc:Built-Using} on the
documentation package.
* examples: these currently get installed into the module package,
but probably belong in the documentation package. Examples are
after all a form of documentation.
* rules: if test_from_numpy is only problematic on 32bit archs,
setting the PYTEST_ADDOPTS variable could be made conditional on
that (so the test still runs on other archs). IIRC, the relevant
variable one could use is DEB_HOST_ARCH_BITS.
* rules/control: sphinx-build is called even if the 'nodoc' build
profile is used. Please honour the build profile (examples at [1]);
documentation-only build-dependencies could also be marked <!nodoc>.
* patches: the comment_get_documenter patch looks like it isn't
Debian-specific and thus could be forwarded upstream?
* lintian: privacy-breach-generic has been overridden, but lintian
identified a real issue (remote build status badge image, via
doc/README.rst:4). Please add a patch for that and remove the
override.
* what is pyvips/pyvips_build.py used for? Is it just part of the
build process via setup.py, and if so, does it need to be
installed? Asking since it's currently part of the module, but it
needs python3-pkgconfig which isn't a dependency of the binary
package (only a build-dep right now).
Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.
[1]https://codesearch.debian.net/search?q=path%3Adebian%2Frules%20filter%20nodoc&literal=1&perpkg=1
pgpoXhcj7UMVg.pgp
Description: OpenPGP digital signature
