Thanks Jaroen, thanks for the review. I have addressed the comments on debian/master in the Python Team repository, commit ded83e2f1d8b38ced4fcbc280e8c7494b835d765.
Point by point:
- changelog/control: removed Mr. Modaresi from Uploaders and updated the
changelog trailer to Michele Cane.
- control: added Built-Using: ${sphinxdoc:Built-Using} to python3-pyvips-doc.
- examples: moved the examples from python3-pyvips to python3-pyvips-doc.
- rules: made the test_from_numpy skip conditional on DEB_HOST_ARCH_BITS ==
32, so it still runs on 64-bit architectures.
- rules/control: honoured the nodoc profile for the Sphinx build and marked
the documentation-only Build-Depends with <!nodoc>.
- patches: I have kept the comment_get_documenter.patch for now and will
forward it upstream.
- lintian: added a patch to remove the remote GitHub Actions badge from the
generated documentation and removed the privacy-breach-generic override.
- pyvips/pyvips_build.py: this is the CFFI build script used via setup.py; it
is not needed at runtime. I removed it from the installed runtime package, so
python3-pkgconfig remains only a build dependency.
QA:
- sbuild -d unstable passed on amd64.
- Upstream tests passed for Python 3.13 and 3.14.
- lintian --display-info --pedantic python-pyvips_3.1.1-1_amd64.changes
reports only the Python dist-info top_level.txt informational tag.
Thanks
Mike
Michele Cane, PhD
On Sunday, 26 July 2026 at 19:09, Jeroen Ploemen <[email protected]> wrote:
> hi Mike,
>
> I took a look at the python-pyvips package, up for sponsorship in the
> Python team:
>
> * changelog/control: mr. Modaresi is still listed as uploader, but no
> longer active as a Debian maintainer.
>
> * control: missing Built-Using: ${sphinxdoc:Built-Using} on the
> documentation package.
>
> * examples: these currently get installed into the module package,
> but probably belong in the documentation package. Examples are
> after all a form of documentation.
>
> * rules: if test_from_numpy is only problematic on 32bit archs,
> setting the PYTEST_ADDOPTS variable could be made conditional on
> that (so the test still runs on other archs). IIRC, the relevant
> variable one could use is DEB_HOST_ARCH_BITS.
>
> * rules/control: sphinx-build is called even if the 'nodoc' build
> profile is used. Please honour the build profile (examples at [1]);
> documentation-only build-dependencies could also be marked <!nodoc>.
>
> * patches: the comment_get_documenter patch looks like it isn't
> Debian-specific and thus could be forwarded upstream?
>
> * lintian: privacy-breach-generic has been overridden, but lintian
> identified a real issue (remote build status badge image, via
> doc/README.rst:4). Please add a patch for that and remove the
> override.
>
> * what is pyvips/pyvips_build.py used for? Is it just part of the
> build process via setup.py, and if so, does it need to be
> installed? Asking since it's currently part of the module, but it
> needs python3-pkgconfig which isn't a dependency of the binary
> package (only a build-dep right now).
>
>
> Once the above comments have been addressed, simply re-add the
> package to the IRC channel topic and/or ping me by e-mail.
>
>
> [1]https://codesearch.debian.net/search?q=path%3Adebian%2Frules%20filter%20nodoc&literal=1&perpkg=1
>
publickey - [email protected] - 0xC017295D.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature
