Control: clone -1 -2
Control: retitle -2 [britney] Add an EOL to the verdict summary line in HTML
output
Control: tag -2 patch
Control: retitle -1 grep-excuses: Use excuses.yaml instead of
update_excuses.html.gz
Control: severity -1 normal
On Mon, Feb 20, 2017 at 10:42:17PM +0100, Christian Marillat wrote:
> $ grep-excuses sawfish-merlin-ugliness
> sawfish-merlin-ugliness (- to 1.3.1-1)
> Migration status: BLOCKED: Rejected/introduces a regression (please see
> below)
> Maintainer: Christian Marillat
> 4589 days old (needed 10 days)
> Not touching package due to block request by freeze (check
> https://release.debian.org/testing/freeze_policy.html if update is needed)
> sawfish-merlin-ugliness has new bugs!
> Updating sawfish-merlin-ugliness introduces new bugs: #800278
> Piuparts tested OK -
> https://piuparts.debian.org/sid/source/s/sawfish-merlin-ugliness.html
>
> When 'grep-excuses Marillat' or grep-excuses 'Christian Marillat' return
> nothing.
This is due to a recent change in the script that generates the
update_excuses.html page, which breaks grep-excuses' parsing.
I'm splitting this bug into two pieces. One, for the release team, to
fix the generation of the HTML so grep-excuses is fixed now, and another
for grep-excuses to start consuming YAML instead of parsing HTML.
I have patches for both bugs, but the YAML one will need to wait until
Buster, since it's essentially a rewrite of that part of grep-excuses.
Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
>From a04d730bb7ba63df17117c3bfc4afd93bab9f37c Mon Sep 17 00:00:00 2001
From: James McCoy <james...@debian.org>
Date: Fri, 24 Feb 2017 23:43:57 -0500
Subject: [PATCH] excuse: Add an EOL to the verdict summary line in HTML output
devscripts' grep-excuses expects each <li> to be on its own line. When
d7a676d0741729bb643e0b8c54b989cb747c6a4b added the verdict summary,
without an EOL, it broke grep-excuses' ability to search by maintainer.
Signed-off-by: James McCoy <james...@debian.org>
---
britney2/excuse.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/britney2/excuse.py b/britney2/excuse.py
index 4dbd703..e301cfe 100644
--- a/britney2/excuse.py
+++ b/britney2/excuse.py
@@ -182,7 +182,7 @@ class Excuse(object):
"""Render the excuse in HTML"""
res = "<a id=\"%s\" name=\"%s\">%s</a> (%s to %s)\n<ul>\n" % \
(self.name, self.name, self.name, self.ver[0], self.ver[1])
- res += "<li>Migration status: %s" % self._format_verdict_summary()
+ res += "<li>Migration status: %s\n" % self._format_verdict_summary()
if self.maint:
res = res + "<li>Maintainer: %s\n" % (self.maint)
if self.section and self.section.find("/") > -1:
--
2.11.0
