Hilko Bengen: > * Niels Thykier: > >>> * Add 33_sshcrypto_DES.patch >>> Replacing all des_ methods and structs with DES_ equivalents. >>> Already implemented in OpenBSD >> >> Why is this done? The patch does not explain why this is a good idea (I >> assume it is, but I am missing the "why"). > > Functions and types prefixed with "des_" are deprecated (defined in > openssl/des_old.h as of OpenSSL 1.0) and have been removed in OpenSSL > 1.1. The patch description should document this. > > Cheers, > -Hilko >
Hi, Thanks for the explanation. I assumed it was something related to an OpenSSL change, but I wasn't sure. I am ok with that change as well. As for the patch description - It says what it does, but it does not explain why AFAICT: > diff -Nru dsniff-2.4b1+debian/debian/patches/33_sshcrypto_DES.patch > dsniff-2.4b1+debian/debian/patches/33_sshcrypto_DES.patch > --- dsniff-2.4b1+debian/debian/patches/33_sshcrypto_DES.patch 1970-01-01 > 01:00:00.000000000 +0100 > +++ dsniff-2.4b1+debian/debian/patches/33_sshcrypto_DES.patch 2017-02-15 > 23:42:16.000000000 +0100 > @@ -0,0 +1,62 @@ > +Description: improves 18_sshcrypto.patch replacing all des_ methods and > structs with DES_ equivalents. > +Author: jca > +Origin: OpenBSD > +--- > +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ > + Thanks, ~Niels
