Control: tags -1 moreinfo Hi Benjamin,
On Thu, 18 Apr 2019 13:01:31 +0200 Benjamin Drung <benjamin.dr...@cloud.ionos.com> wrote: > This version fixes the test_xen_virtual test case (bug #922352) and > exposes tornado4 as tornado for zmq.eventloop.ioloop (bug #924763). Our > salt 2018.3.3+dfsg1-1 package introduced a big patch to use > python3-tornado4 (instead of python3-tornado) due to missing support for > tornado version 5. Without the fix for #924763, zmq.eventloop.ioloop > will import tornado version 5 (if python3-tornado is installed). Both bugs have severity normal. Do you really want to bother now or is the severity not correct (then please fix that and elaborate)? > I also included fix-various-spelling-mistakes.patch which fixes several > spelling mistakes. Because this patch file is long, I excluded it from the > attached debdiff. Bugs can be introduced that way. I am not going to review that diff, fixing spelling mistakes at this moment isn't appropriate unless these mistakes are crucial somewhere. > This version also switches from the a pre-release git snapshot to the > official 2018.3.4 release. The only difference between this snapshot and > the release are two commits ("Fix ssh on Windows" and "Update url to > libsodium for mac builds") and that the release tarball ships less files > than what can be found in git. If that was all (salt/modules/ssh.py and tests/integration/modules/test_ssh.py), I could except it. But with less files, there is also a changes that ... > For that reason, the attached debdiff is created with this command: > > debdiff --exclude fix-various-spelling-mistakes.patch > salt_2018.3.4~git20180207+dfsg1-1.dsc salt_2018.3.4+dfsg1-2.dsc | > filterdiff -i '*/debian/*' -i '*/tests/*/test_ssh.py' -i > '*/salt/modules/ssh.py' -i '*/pkg/osx/build_env.sh' > > salt_2018.3.4+dfsg1-2.debdiff > > Alternatively this more simple git diff command could be used: > > git diff --diff-filter=ACM > debian/2018.3.4_git20180207+dfsg1-1..debian/2018.3.4+dfsg1-2 > > You can also look at all the individual commits on salsa: > https://salsa.debian.org/salt-team/salt/compare/debian%2F2018.3.4_git20180207+dfsg1-1...debian%2F2018.3.4+dfsg1-2 > > All 7575 unittest succeeded and I successfully tested this new salt > version on Debian unstable with our production environment setup > (running the highstate on a salt minion connected to the salt master). > > unblock salt/2018.3.4+dfsg1-2 You didn't even elaborate on all the (at this phase of the release inappropriate) changes to the packaging. There is even a newer version than the one you already mention in a follow up in this bug. I am not going to unblock this package, and seen the amount of time your request stayed open and the proposed changes, I don't think my colleagues are tempted either. I see that salt is marked for autoremoval. I suggest you aim for a targeted fix. Paul
signature.asc
Description: OpenPGP digital signature