Bug#935411: buster-pu: package dbconfig-common/2.0.11+deb10u1

[Paul Gevers]

Package: release.debian.org
User: release.debian....@packages.debian.org
Usertags: pu
Tags: buster
Severity: normal

Hi all,

After the buster release, it was discovered that bash changed its POSIX
behavior for `local` variables (bug #935115). This was first reported
against dbconfig-common (bug #934027), because the change in bash causes
other packages, that use dbconfig-common to setup their database, to
fail during installation if the system administrator is using bash for
/bin/sh. I hope that the bug in bash gets fixed, but a work-around in
dbconfig-common is available and uploaded to unstable and pu.

I improved the autopkgtest to run its tests with /bin/sh as was my
intention. It would have caught this issue before bash migrated to buster.

Please consider accepting dbconfig-common 2.0.11+deb10u1.

Paul

diff -Nru dbconfig-common-2.0.11/debian/changelog 
dbconfig-common-2.0.11+deb10u1/debian/changelog
--- dbconfig-common-2.0.11/debian/changelog     2018-12-13 10:32:33.000000000 
+0100
+++ dbconfig-common-2.0.11+deb10u1/debian/changelog     2019-08-18 
21:23:05.000000000 +0200
@@ -1,3 +1,14 @@
+dbconfig-common (2.0.11+deb10u1) buster; urgency=medium
+
+  [ Marius Burkard ]
+  * Fix regression with /bin/sh pointing to bash due to changes in its
+    POSIX behaviour (Closes: #934027)
+
+  [ Paul Gevers ]
+  * tests: use sh instead of hardcoded *sh to catch issues like the above
+
+ -- Paul Gevers <elb...@debian.org>  Sun, 18 Aug 2019 21:23:05 +0200
+
 dbconfig-common (2.0.11) unstable; urgency=medium
 
   [ Sunil Mohan Adapa ]
diff -Nru dbconfig-common-2.0.11/internal/mysql 
dbconfig-common-2.0.11+deb10u1/internal/mysql
--- dbconfig-common-2.0.11/internal/mysql       2018-12-13 10:32:33.000000000 
+0100
+++ dbconfig-common-2.0.11+deb10u1/internal/mysql       2019-08-18 
21:23:05.000000000 +0200
@@ -195,7 +195,8 @@
         if [ "${dbc_mysql_createdb_encoding:-}" ]; then
             extrasql=" CHARACTER SET '$dbc_mysql_createdb_encoding'";
         fi
-        _dbc_nodb="yes" dbc_mysql_exec_command "CREATE DATABASE 
\`$dbc_dbname\`${extrasql:-}"
+        _dbc_nodb="yes"
+        dbc_mysql_exec_command "CREATE DATABASE \`$dbc_dbname\`${extrasql:-}"
         ret=$?
         _dbc_nodb=""
         if [ "$ret" = "0" ]; then
@@ -314,7 +315,8 @@
 FLUSH PRIVILEGES;
 EOF
         l_dbname=$dbc_dbname
-        _dbc_nodb="yes" dbc_mysql_exec_file "$l_sqlfile"
+        _dbc_nodb="yes"
+        dbc_mysql_exec_file "$l_sqlfile"
         l_ret=$?
         _dbc_nodb=""
 
diff -Nru dbconfig-common-2.0.11/test/runtests.sh 
dbconfig-common-2.0.11+deb10u1/test/runtests.sh
--- dbconfig-common-2.0.11/test/runtests.sh     2018-12-13 10:32:33.000000000 
+0100
+++ dbconfig-common-2.0.11+deb10u1/test/runtests.sh     2019-08-18 
21:23:05.000000000 +0200
@@ -14,13 +14,13 @@
     printf "# # #\n# # # Test: $t\n# # #\n"
     printf "# #\n# # Shell: bash\n# #\n"
     rm /bin/sh && ln -s bash /bin/sh
-    bash $t
+    sh $t
     printf "\n# #\n# # Shell: dash\n# #\n"
     rm /bin/sh && ln -s dash /bin/sh
-    dash $t
+    sh $t
     printf "# #\n# # Shell: lksh\n# #\n"
     rm /bin/sh && ln -s lksh /bin/sh
-    lksh $t
+    sh $t
 #    printf "# #\n# # Shell: posh\n# #\n"
 #    rm /bin/sh && ln -s posh /bin/sh
 #    posh $t

signature.asc
Description: OpenPGP digital signature