Control: tags -1 + confirmed On Wed, 2020-01-29 at 01:03 +0200, Adrian Bunk wrote: > Control: tags -1 - moreinfo > > On Tue, Jan 28, 2020 at 10:34:00PM +0000, Adam D. Barratt wrote: > > Control: tags -1 + moreinfo > > > > On Sun, 2020-01-26 at 21:57 +0200, Adrian Bunk wrote: > > > * Backport upstream patch "config: extend validity of testdata > > > certs": > > > As the previous test certificates were set to expire on 2019- > > > 07- > > > 13, > > > causing TestNewClientFromConfig to fail after that date. > > > See https://github.com/prometheus/common/pull/186 > > > (Closes: #949189) > > > > I'm hoping that doesn't imply having to rebuild any of the > > (several) r- > > deps? > > This is testdata for build-time tests of golang-github-prometheus- > common, > not certs that are useful for anything (arguably they should be > generated > at build time). > > These testdata certs are also shipped in the -dev package. > I haven't seen any build failures due to them in other packages. > And at runtime they are not available since they are in a -dev > package
Thanks for the confirmation. Please go ahead. Regards, Adam