Control: tags -1 -moreinfo +confirmed

On Thu, 2020-05-28 at 14:20 +0200, Sebastian Andrzej Siewior wrote:
> On 2020-05-27 22:28:44 [+0100], Adam D. Barratt wrote:
> > Control: tags -1 + moreinfo
> > 
> > On Sun, 2020-05-24 at 17:47 +0200, Sebastian Andrzej Siewior wrote:
> > > As part of this update I also introduce the `libclamunrar'
> > > package
> > > which only purpose is to depend on libclamunrar9. On the last
> > > soname
> > > bump not everyone noticed that the soname of libclamunrar changed
> > > and
> > > ended up with no unrar support. Due to its non-free nature we
> > > can't
> > > depend on it so it has been suggested to use this package which
> > > will
> > > remain on the next soname bump and pull-in the new libclamunrarX
> > > library.
> > 
> > Does anything pull the metapackage in on user systems, or is the
> > assumption that they will read the changelog and install it?
> 
> Not yet. In packaging git for clamav there has been a Suggests: added
> for libclamunrar. This is as far as we can go given the non-free
> nature.
> I didn't add the Suggests to the clamav package for (old)-stable
> because we don't have it in unstable just yet and I didn't want to
> upload it with this as the only change.
> If you approve / prefer / makes sense I could go ahead and add it to
> the pu before we have it in unstable.

I meant more from the perspective of existing users of libclamunrar,
for those who previously missed the package name change and would
benefit most from the metapackage. I'm not sure what specifically would
help, though.

I'd be OK with the Suggests from the clamav side, assuming it is going
to end up in unstable before too long.

> > > This version of libclamunrar was in unstable 20th. I didn't
> > > backport the packaging related changes while preparing this
> > > version (I did include the update of the copyright file).
> > 
> > There seem to be a few, e.g. the removal of the dh_auto_install
> > override, the dropping of "--disable-clamav --without-pcre" from
> > the configure invocation, and most of the Build-Depends being
> > removed.
> 
> The override of dh_auto_install was required to remove the .la files
> so they don't end up in the final package. With the addition of the
> package, the folders changed and so the removal is no longer
> required.
> 
> The libclamunrar is a split of the clamav package and historically
> included its (clamav's) configure.ac with the required m4 folder and
> a stripped down Makefile.am. The only reason why pcre was disabled or
> libssl-dev listed as a dependency was to keep the configure script
> happy. None of this was really required by the libclamunrar package.

Thanks for explaining. It would have helped to include that information
in the original request. :-) (I'm not sure if it's worth noting in the
changelog.)

Please feel free to go ahead.

Regards,

Adam

Reply via email to