Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package apt-transport-s3 We need this package to be included in the Bullseye release, changeset is minimal and only contains fix for the RC bug (#986647). Impact of this change should be minimal as the change is really simple type casting. Set of manual tests including fetching and installing packages via apt with this transport has been run successfully. [ Checklist ] [X] all changes are documented in the d/changelog [X] I reviewed all changes and I approve them [X] attached source debdiff against the package in testing unblock apt-transport-s3/2.0.0-2 *** /tmp/apt-transport-s3.debdiff diff -Nru apt-transport-s3-2.0.0/debian/changelog apt-transport-s3-2.0.0/debian/changelog --- apt-transport-s3-2.0.0/debian/changelog 2019-08-27 14:22:40.000000000 +0100 +++ apt-transport-s3-2.0.0/debian/changelog 2021-06-03 20:20:49.000000000 +0100 @@ -1,3 +1,9 @@ +apt-transport-s3 (2.0.0-2) unstable; urgency=medium + + * Applying patch fixing string opperations (Closes: #986647) + + -- Marcin Kulisz <deb...@kulisz.net> Thu, 03 Jun 2021 20:20:49 +0100 + apt-transport-s3 (2.0.0-1) unstable; urgency=medium [ Hayden Myers ] diff -Nru apt-transport-s3-2.0.0/debian/patches/0001-Added-explicit-string-casing-Closes-986647.patch apt-transport-s3-2.0.0/debian/patches/0001-Added-explicit-string-casing-Closes-986647.patch --- apt-transport-s3-2.0.0/debian/patches/0001-Added-explicit-string-casing-Closes-986647.patch 1970-01-01 01:00:00.000000000 +0100 +++ apt-transport-s3-2.0.0/debian/patches/0001-Added-explicit-string-casing-Closes-986647.patch 2021-06-03 20:20:49.000000000 +0100 @@ -0,0 +1,24 @@ +From: Marcin Kulisz <deb...@kulisz.net> +Date: Thu, 3 Jun 2021 20:10:24 +0100 +Subject: Added explicit string casing (Closes: #986647) + +--- + s3 | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/s3 b/s3 +index 01b1d9d..83a6dfa 100755 +--- a/s3 ++++ b/s3 +@@ -187,8 +187,9 @@ class AWSCredentials(object): + + if data.get("AccessKeyId") is None: + self.__get_role() +- data = self.__request_json(urllib.parse.urljoin(self.credentials_metadata, +- self.iamrole)) ++ data = self.__request_json(urllib.parse.urljoin( ++ str(self.credentials_metadata, 'utf-8'), ++ str(self.iamrole, 'utf-8'))) + + self.access_key = data['AccessKeyId'] + if self.access_key is None or self.access_key == '': diff -Nru apt-transport-s3-2.0.0/debian/patches/series apt-transport-s3-2.0.0/debian/patches/series --- apt-transport-s3-2.0.0/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ apt-transport-s3-2.0.0/debian/patches/series 2021-06-03 20:20:49.000000000 +0100 @@ -0,0 +1 @@ +0001-Added-explicit-string-casing-Closes-986647.patch