Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package puppet-module-puppetlabs-haproxy [ Reason ] The latest update fix haproxy version detection (ie: puppet fact). [ Impact ] Wrong haproxy detection and red line when the agent runs. [ Tests ] I did a manual check and it fixes the issue. [ Risks ] Not much risks: the fact is already broken in 2.1.0-4 and 2.1.0-5 fixes it. A broken fact doesn't break the puppet module. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing unblock puppet-module-puppetlabs-haproxy/2.1.0-4
diff -Nru puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog --- puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog 2022-01-04 17:24:44.000000000 +0100 +++ puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog 2023-03-13 09:01:56.000000000 +0100 @@ -1,3 +1,10 @@ +puppet-module-puppetlabs-haproxy (2.1.0-5) unstable; urgency=medium + + * Add a fix for the haproxy fact, taking upstream latest version of the + parsing. + + -- Thomas Goirand <z...@debian.org> Mon, 13 Mar 2023 09:01:56 +0100 + puppet-module-puppetlabs-haproxy (2.1.0-4) unstable; urgency=medium * Clean up update-alternatives handling (Closes: #989237). diff -Nru puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/fix-haproxy-version-detection.patch puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/fix-haproxy-version-detection.patch --- puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/fix-haproxy-version-detection.patch 1970-01-01 01:00:00.000000000 +0100 +++ puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/fix-haproxy-version-detection.patch 2023-03-13 09:01:56.000000000 +0100 @@ -0,0 +1,17 @@ +Description: Fix HAProxy version detection +Author: Thomas Goirand <z...@debian.org> +Bug-Debian: https://bugs.debian.org/989237 +Origin: upstream +Last-Update: 2023-03-13 + +--- puppet-module-puppetlabs-haproxy-2.1.0.orig/lib/facter/haproxy_version.rb ++++ puppet-module-puppetlabs-haproxy-2.1.0/lib/facter/haproxy_version.rb +@@ -16,7 +16,7 @@ if defined?(Facter::Util::Resolution.whi + haproxy_version_cmd = 'haproxy -v 2>&1' + haproxy_version_result = Facter::Util::Resolution.exec(haproxy_version_cmd) + setcode do +- haproxy_version_result.to_s.lines.first.strip.split(%r{HA-Proxy})[1].strip.split(%r{version})[1].strip.split(%r{((\d+\.){2,}\d+).*})[1] ++ haproxy_version_result.to_s.lines.first.strip.split(%r{HA?.Proxy})[1].strip.split(%r{version})[1].strip.split(%r{((\d+\.){2,}\d+).*})[1] + end + end + end diff -Nru puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/series puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/series --- puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ puppet-module-puppetlabs-haproxy-2.1.0/debian/patches/series 2023-03-13 09:01:56.000000000 +0100 @@ -0,0 +1 @@ +fix-haproxy-version-detection.patch