Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

Please unblock package live-installer, see also the discussion on
https://lists.debian.org/debian-cd/2023/04/msg00009.html which leads to this
unblock request.

[ Reason ]
The Debian installer, when started from a live image, needs about 2 additional
minutes after
the 'Installation is complete, so it is time to boot into your new system'
prompt is shown. This additional delay can be removed by performing the step to
remove the live-specific packages earlier, ensuring that only one long non-
interactive phase is present in the installer. The regular installation takes
about 20-30 minutes.

[ Impact ]
The user will have to wait an additional 2 minutes after pressing the button to
reboot the computer (because that's the time required to remove all live-
related packages on a non Qt-based system).
An inconvenience, which is not necessary, and will be avoided by this change.

[ Tests ]
The new version of live-installer is working correctly, as can be seen by a sid
build of the live image on openQA:
https://openqa.debian.net/tests/138478/video?filename=video.ogv
See the movie at 0:50-0:56

[ Risks ]
The patch is a trivial rename of the hook file from 60remove-live-packages to
14remove-live-packages

The other changes in the diff are the usual Janitor and modernisation changes.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
* kibi asked me to file the unblock. I'm not a DD (yet?) and would need a
sponsor if additional changes need to be made/reverted.
* This bug report might be non-standard, because reportbug crashed while
generating this unblock report (to be filed later)

With kind regards,
Roland Clobus
Working on the Debian live images

unblock live-installer/58
diff -Nru live-installer-57/AUTHORS live-installer-58/AUTHORS
--- live-installer-57/AUTHORS   2018-08-10 21:22:33.000000000 +0200
+++ live-installer-58/AUTHORS   2019-04-15 19:43:07.000000000 +0200
@@ -1,4 +1,4 @@
-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: live-installer
 Upstream-Contact: debian-b...@lists.debian.org
 Source: http://snapshot.debian.org/package/live-installer/
diff -Nru live-installer-57/ChangeLog live-installer-58/ChangeLog
--- live-installer-57/ChangeLog 2019-01-17 13:03:40.000000000 +0100
+++ live-installer-58/ChangeLog 2019-04-15 19:43:07.000000000 +0200
@@ -1,6 +1,32 @@
+live-installer (58) unstable; urgency=medium
+
+  [ Jonathan Carter ]
+  * Fix typo in previous changelog entry
+  * Update standards version to 4.6.1
+  * Upload MR!3 from Roland Clobus
+    - Remove the live packages before the cdrom is unmounted
+  * Remove myself from uploaders
+
+  [ Cyril Brulebois ]
+  * Remove Christian Perrier from Uploaders, with many thanks for all
+    his contributions over the years! (Closes: #927548)
+
+  [ Holger Wansing ]
+  * Remove trailing whitespace from changelog file, to fix lintian tag.
+  * Change Format URI in copyright file to https, to fix lintian tag.
+
+  [ Debian Janitor ]
+  * Add missing ${misc:Depends} to Depends for live-installer.
+  * Drop custom source compression, custom source compression level.
+  * Bump debhelper from old 10 to 13.
+  * Set debhelper-compat version in Build-Depends.
+  * Update standards version to 4.6.0, no changes needed.
+
+ -- Jonathan Carter <j...@debian.org>  Mon, 15 Apr 2019 17:43:07 +0000
+
 live-installer (57) unstable; urgency=medium
 
-  * Add calamares-settings-debian as packaged to be removed at
+  * Add calamares-settings-debian as package to be removed at
     the end of installation
   * Add self to uploaders
   * Update standards-version to 4.3.0
@@ -78,7 +104,7 @@
 live-installer (48) unstable; urgency=low
 
   * Drop cruft files from my unclean git copy. Sigh:
-    - live-installer.d/remove-packages 
+    - live-installer.d/remove-packages
     - live-installer.d/xserver-xorg
 
  -- Christian Perrier <bubu...@debian.org>  Mon, 09 Mar 2015 16:56:58 +0100
@@ -465,7 +491,7 @@
   * Lithuanian (lt.po) by Kęstutis Biliūnas
   * Slovenian (sl.po) by Vanja Cvelbar
 
- -- Daniel Baumann <dan...@debian.org>  Thu, 18 May 2010 18:53:34 +0200
+ -- Daniel Baumann <dan...@debian.org>  Tue, 18 May 2010 18:53:34 +0200
 
 live-installer (17) unstable; urgency=low
 
diff -Nru live-installer-57/COPYING live-installer-58/COPYING
--- live-installer-57/COPYING   2018-08-10 21:22:33.000000000 +0200
+++ live-installer-58/COPYING   2019-04-15 19:43:07.000000000 +0200
@@ -1,4 +1,4 @@
-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: live-installer
 Upstream-Contact: debian-b...@lists.debian.org
 Source: http://snapshot.debian.org/package/live-installer/
diff -Nru live-installer-57/debian/changelog live-installer-58/debian/changelog
--- live-installer-57/debian/changelog  2019-01-17 13:03:40.000000000 +0100
+++ live-installer-58/debian/changelog  2019-04-15 19:43:07.000000000 +0200
@@ -1,6 +1,32 @@
+live-installer (58) unstable; urgency=medium
+
+  [ Jonathan Carter ]
+  * Fix typo in previous changelog entry
+  * Update standards version to 4.6.1
+  * Upload MR!3 from Roland Clobus
+    - Remove the live packages before the cdrom is unmounted
+  * Remove myself from uploaders
+
+  [ Cyril Brulebois ]
+  * Remove Christian Perrier from Uploaders, with many thanks for all
+    his contributions over the years! (Closes: #927548)
+
+  [ Holger Wansing ]
+  * Remove trailing whitespace from changelog file, to fix lintian tag.
+  * Change Format URI in copyright file to https, to fix lintian tag.
+
+  [ Debian Janitor ]
+  * Add missing ${misc:Depends} to Depends for live-installer.
+  * Drop custom source compression, custom source compression level.
+  * Bump debhelper from old 10 to 13.
+  * Set debhelper-compat version in Build-Depends.
+  * Update standards version to 4.6.0, no changes needed.
+
+ -- Jonathan Carter <j...@debian.org>  Mon, 15 Apr 2019 17:43:07 +0000
+
 live-installer (57) unstable; urgency=medium
 
-  * Add calamares-settings-debian as packaged to be removed at
+  * Add calamares-settings-debian as package to be removed at
     the end of installation
   * Add self to uploaders
   * Update standards-version to 4.3.0
@@ -78,7 +104,7 @@
 live-installer (48) unstable; urgency=low
 
   * Drop cruft files from my unclean git copy. Sigh:
-    - live-installer.d/remove-packages 
+    - live-installer.d/remove-packages
     - live-installer.d/xserver-xorg
 
  -- Christian Perrier <bubu...@debian.org>  Mon, 09 Mar 2015 16:56:58 +0100
@@ -465,7 +491,7 @@
   * Lithuanian (lt.po) by Kęstutis Biliūnas
   * Slovenian (sl.po) by Vanja Cvelbar
 
- -- Daniel Baumann <dan...@debian.org>  Thu, 18 May 2010 18:53:34 +0200
+ -- Daniel Baumann <dan...@debian.org>  Tue, 18 May 2010 18:53:34 +0200
 
 live-installer (17) unstable; urgency=low
 
diff -Nru live-installer-57/debian/compat live-installer-58/debian/compat
--- live-installer-57/debian/compat     2018-08-10 21:22:33.000000000 +0200
+++ live-installer-58/debian/compat     1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-10
diff -Nru live-installer-57/debian/control live-installer-58/debian/control
--- live-installer-57/debian/control    2019-01-17 13:03:40.000000000 +0100
+++ live-installer-58/debian/control    2019-04-15 19:43:07.000000000 +0200
@@ -2,11 +2,9 @@
 Section: debian-installer
 Priority: optional
 Maintainer: Debian Install System Team <debian-b...@lists.debian.org>
-Uploaders: Raphaël Hertzog <hert...@debian.org>,
-           Christian Perrier <bubu...@debian.org>,
-           Jonathan Carter <j...@debian.org>
-Build-Depends: debhelper (>= 10), po-debconf
-Standards-Version: 4.3.0
+Uploaders: Raphaël Hertzog <hert...@debian.org>
+Standards-Version: 4.6.1
+Build-Depends: debhelper-compat (= 13), po-debconf
 Vcs-Browser: https://salsa.debian.org/installer-team/live-installer
 Vcs-Git: https://salsa.debian.org/installer-team/live-installer.git
 
@@ -15,12 +13,13 @@
 Architecture: any
 Depends: archdetect,
          attr-udeb,
-         base-installer (>= 1.105),
-         busybox-udeb (>= 1:1.13.3),
+         base-installer,
+         busybox-udeb,
          cdebconf-udeb,
          created-fstab,
          mounted-partitions,
-         ${shlibs:Depends}
+         ${shlibs:Depends},
+         ${misc:Depends}
 Provides: installed-base, kernel-installer
 XB-Installer-Menu-Item: 6490
 Description: Install the system
diff -Nru live-installer-57/debian/copyright live-installer-58/debian/copyright
--- live-installer-57/debian/copyright  2018-08-10 21:22:33.000000000 +0200
+++ live-installer-58/debian/copyright  2019-04-15 19:43:07.000000000 +0200
@@ -1,4 +1,4 @@
-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: live-installer
 Upstream-Contact: debian-b...@lists.debian.org
 Source: http://snapshot.debian.org/package/live-installer/
diff -Nru live-installer-57/debian/gbp.conf live-installer-58/debian/gbp.conf
--- live-installer-57/debian/gbp.conf   2018-08-10 21:22:33.000000000 +0200
+++ live-installer-58/debian/gbp.conf   2019-04-15 19:43:07.000000000 +0200
@@ -1,2 +1,2 @@
-[buildpackage]
+[DEFAULT]
 debian-tag = "%(version)s"
diff -Nru live-installer-57/debian/source/options 
live-installer-58/debian/source/options
--- live-installer-57/debian/source/options     2018-08-10 21:22:33.000000000 
+0200
+++ live-installer-58/debian/source/options     1970-01-01 01:00:00.000000000 
+0100
@@ -1,2 +0,0 @@
-compression = xz
-compression-level = 9
diff -Nru live-installer-57/finish-install.d/14remove-live-packages 
live-installer-58/finish-install.d/14remove-live-packages
--- live-installer-57/finish-install.d/14remove-live-packages   1970-01-01 
01:00:00.000000000 +0100
+++ live-installer-58/finish-install.d/14remove-live-packages   2019-04-15 
19:43:07.000000000 +0200
@@ -0,0 +1,38 @@
+#!/bin/sh -e
+
+do_manual_removal=true
+
+# Remove packages as specified in specific package removal list
+for list in /cdrom/live/filesystem.packages-remove; do
+       if [ -e $list ]; then
+               do_manual_removal=
+               do_initrd=true
+
+               for package in $(awk '{ print $1 }' $list); do
+                       if [ -f /target/var/lib/dpkg/info/$package.list ]; then
+                               packages="$packages $package"
+                       fi
+               done
+
+               in-target apt-get --yes purge $packages
+       fi
+done
+
+# Manually removing packages live specific packages:
+# - Debian: live-boot, live-config, debian-installer-launcher
+# - Ubuntu: casper
+
+if [ $do_manual_removal ]; then
+       for package in live-boot live-boot-initramfs-tools live-config 
live-config-runit live-config-systemd live-config-sysvinit live-config-upstart 
debian-installer-launcher casper calamares-settings-debian; do
+               if [ -f /target/var/lib/dpkg/info/$package.list ]; then
+                       in-target apt-get --yes purge $package
+                       do_initrd=true
+               fi
+       done
+fi
+
+if [ $do_initrd ]; then
+       in-target update-initramfs -k all -u
+fi
+
+in-target apt-get --yes autoremove
diff -Nru live-installer-57/finish-install.d/60remove-live-packages 
live-installer-58/finish-install.d/60remove-live-packages
--- live-installer-57/finish-install.d/60remove-live-packages   2019-01-17 
13:03:00.000000000 +0100
+++ live-installer-58/finish-install.d/60remove-live-packages   1970-01-01 
01:00:00.000000000 +0100
@@ -1,38 +0,0 @@
-#!/bin/sh -e
-
-do_manual_removal=true
-
-# Remove packages as specified in specific package removal list
-for list in /cdrom/live/filesystem.packages-remove; do
-       if [ -e $list ]; then
-               do_manual_removal=
-               do_initrd=true
-
-               for package in $(awk '{ print $1 }' $list); do
-                       if [ -f /target/var/lib/dpkg/info/$package.list ]; then
-                               packages="$packages $package"
-                       fi
-               done
-
-               in-target apt-get --yes purge $packages
-       fi
-done
-
-# Manually removing packages live specific packages:
-# - Debian: live-boot, live-config, debian-installer-launcher
-# - Ubuntu: casper
-
-if [ $do_manual_removal ]; then
-       for package in live-boot live-boot-initramfs-tools live-config 
live-config-runit live-config-systemd live-config-sysvinit live-config-upstart 
debian-installer-launcher casper calamares-settings-debian; do
-               if [ -f /target/var/lib/dpkg/info/$package.list ]; then
-                       in-target apt-get --yes purge $package
-                       do_initrd=true
-               fi
-       done
-fi
-
-if [ $do_initrd ]; then
-       in-target update-initramfs -k all -u
-fi
-
-in-target apt-get --yes autoremove

Reply via email to