Bug#1034757: unblock (pre-approval): scilab/6.1.1+dfsg2-5 libjogl2-java/2.3.2+dfsg-10 gluegen2/2.3.2-9

[Pierre Gruet]

Control: tags -1 - moreinfo

Hi Paul,

Le 27/04/2023 à 11:38, Paul Gevers a écrit :

Control: tags -1 moreinfo

Hi Pierre,

On Sun, 23 Apr 2023 17:27:30 +0200 Pierre Gruet <p...@debian.org> wrote:

This unblock would lead to new upstream versions (with some packaging work more complex than just refreshing patches) of gluegen2 and libjogl2 shipped into Bookworm, which I trust to be OK as they have only one rdep, king, which works

well with them.

Are targeted fixes an option? We're well past new upstreams being acceptable [1] unless they are targeted fixes themselves.

Below is my proposal:

[ Reason ]



[ Impact ]

If the unblock is not granted, scilab will remain unusable in Bookworm.
If it is granted, then it will be working except for plotting.

[ Tests ]



[ Risks ]



[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes (did them myself) and I approve them
  [X] attach debdiffs of the locally built package against the package
      in testing

Thanks for looking at my proposal. I understand well this is not feasible as is. Indeed the fixes I proposed are quite important as they require a new upstream version of 2 packages. Also, working around RC bug #1034752 in src:gluegen2 requires quite a lot of Debian-specific changes. So I now propose to do something simpler, in order to have Scilab be able to start and work plainly except for plotting (which was also the case in Bullseye anyway), fixing RC bug #1033496. In order to get a pre-approval, I only did the change locally (source debdiff attached), will upload to unstable if granted. Currently, the key package scilab/6.1.1+dfsg2-5 in sid/testing does not start since we have openjdk-17 as default Java machine, see grave bug #1033496: it is unusable right now. I changed one line in the source, built it in a clean chroot, installed in on my machine running Bookworm and could use all of Scilab features (plotting aside). No risk, as we would not change the biinaries but only the shell wrapper that invokes them with the correct environment variables.

Paul

PS: your message didn't reach our list, which is a bad sign about the size of the changes.

That's right...!

Best,

--
Pierre

diff -Nru scilab-6.1.1+dfsg2/debian/changelog scilab-6.1.1+dfsg2/debian/changelog
--- scilab-6.1.1+dfsg2/debian/changelog	2023-03-11 16:23:07.000000000 +0100
+++ scilab-6.1.1+dfsg2/debian/changelog	2023-04-27 12:37:49.000000000 +0200
@@ -1,3 +1,11 @@
+scilab (6.1.1+dfsg2-6) UNRELEASED; urgency=medium
+
+  * Team upload
+  * Adding another --add-opens clause to the scilab invocation to avoid the
+    Exception at GUI start (Closes: #1033496)
+
+ -- Pierre Gruet <p...@debian.org>  Thu, 27 Apr 2023 12:37:49 +0200
+
 scilab (6.1.1+dfsg2-5) unstable; urgency=medium
 
   * Team upload
diff -Nru scilab-6.1.1+dfsg2/debian/patches/populating_java_options_by_default.patch scilab-6.1.1+dfsg2/debian/patches/populating_java_options_by_default.patch
--- scilab-6.1.1+dfsg2/debian/patches/populating_java_options_by_default.patch	2023-03-11 14:13:54.000000000 +0100
+++ scilab-6.1.1+dfsg2/debian/patches/populating_java_options_by_default.patch	2023-04-27 12:36:03.000000000 +0200
@@ -14,7 +14,7 @@
 +# We initialize _JAVA_OPTIONS so that the right paths are looked into and we
 +# add the needed --add-opens to work with OpenJDK 17.
 +if ! echo "${_JAVA_OPTIONS}" | grep -q "java\.library\.path" ; then
-+    _JAVA_OPTIONS="${_JAVA_OPTIONS} -Djava.library.path=/usr/lib/jni:/usr/lib/scilab --add-opens=java.desktop/sun.awt.X11=ALL-UNNAMED --add-opens=java.desktop/sun.java2d.opengl=ALL-UNNAMED"
++    _JAVA_OPTIONS="${_JAVA_OPTIONS} -Djava.library.path=/usr/lib/jni:/usr/lib/scilab --add-opens=java.desktop/sun.awt.X11=ALL-UNNAMED --add-opens=java.desktop/sun.java2d.opengl=ALL-UNNAMED --add-opens=java.desktop/javax.swing.plaf.basic=ALL-UNNAMED"
 +fi
 +
  if test ! -z "$SCIVERBOSE"; then

OpenPGP_signature
Description: OpenPGP digital signature