pre-approval for perl 5.10.0-15 changes

[Niko Tyni]

Hi release team,

there's an RC bug open in request-tracker3.6 (#498692, dog slow web
interface due to Sys::Syslog slowness) that could be worked around
there in various ways but IMO should really be fixed in the perl package
(cloned as #498776).

I'd also like to fix a 5.10 regression that makes Perl crash with in-place
sorting, #498769.

Please ack/nack the attached patches. Barring any surprises, I'd like
to upload perl 5.10.0-15 in a few days when -14 has entered testing.

(Yes, I know I called -14 the final one for Lenny. Sorry.)

Thanks,
-- 
Niko Tyni   [EMAIL PROTECTED]

Fix Sys::Syslog slowness when logging with non-native mechanisms. (Closes: 
#498776)

Revert the 0.25 second timeout change that was added in 0.19 to address
an OSX problem with UDP sockets and ICMP responses.

Fixed upstream in Sys::Syslog 0.25, which changes the timeout default
to 0 again on non-OSX hosts and makes it configurable with setlogsock().
diff --git a/ext/Sys/Syslog/Syslog.pm b/ext/Sys/Syslog/Syslog.pm
index 899f25b..7037e18 100644
--- a/ext/Sys/Syslog/Syslog.pm
+++ b/ext/Sys/Syslog/Syslog.pm
@@ -741,7 +741,7 @@ sub connection_ok {
 
     my $rin = '';
     vec($rin, fileno(SYSLOG), 1) = 1;
-    my $ret = select $rin, undef, $rin, 0.25;
+    my $ret = select $rin, undef, $rin, 0;
     return ($ret ? 0 : 1);
 }
 

Fix memory corruption with in-place sorting. (Closes: #498769)

[perl #54758]

Fixed in bleadperl by change 33937.
diff --git a/pp_sort.c b/pp_sort.c
index 582b811..1d38bc3 100644
--- a/pp_sort.c
+++ b/pp_sort.c
@@ -1553,11 +1553,12 @@ PP(pp_sort)
        max = AvFILL(av) + 1;
        if (SvMAGICAL(av)) {
            MEXTEND(SP, max);
-           p2 = SP;
            for (i=0; i < max; i++) {
                SV **svp = av_fetch(av, i, FALSE);
                *SP++ = (svp) ? *svp : NULL;
            }
+           SP--;
+           p1 = p2 = SP - (max-1);
        }
        else {
            if (SvREADONLY(av))
@@ -1713,7 +1714,7 @@ PP(pp_sort)
        SvREADONLY_off(av);
     else if (av && !sorting_av) {
        /* simulate pp_aassign of tied AV */
-       SV** const base = ORIGMARK+1;
+       SV** const base = MARK+1;
        for (i=0; i < max; i++) {
            base[i] = newSVsv(base[i]);
        }