Control: tag -1 confirmed

Hi,

On Sat, Feb 16, 2013 at 04:20:45PM -0500, Michael Gilbert wrote:
> On Sat, Feb 16, 2013 at 4:18 PM, Michael Gilbert wrote:
> >> I've attached an updated proposed patch, which also fixes #698582 (and
> >> consequentially #700363).
> > File attached.
> Really attached this time ...

thanks. Please go ahead. One tiny remark, though:

+       if [ -e /etc/dhcp/dhclient.conf ] && \
+               [ "`md5sum /etc/dhcp/dhclient.conf  | awk '{print $1;}'`" = 
6e3910d75cd5cde0042ecb6d48492ae9 ]; then
+               sed -i -e 
's/rfc3442-classless-static-routes;/rfc3442-classless-static-routes, 
ntp-servers;/' /etc/dhcp/dhclient.conf
+       fi

Please don't do things with awk that can be realized with cut,
especially in a preinst. But since awk is still pseudo-essential
(pre-depends of base-files) in wheezy, it doesn't make a difference.

Kind regards
Philipp Kern

Attachment: signature.asc
Description: Digital signature

Reply via email to