Small nits on commit messages follow. On Sun, Jul 27, 2014 at 09:45:07PM +0200, Niels Thykier wrote: > >From 7161a3eff24d2a073911c3d132df623ba499c927 Mon Sep 17 00:00:00 2001 > From: Niels Thykier <ni...@thykier.net> > Date: Sun, 27 Jul 2014 16:56:37 +0200 > Subject: [PATCH 02/11] britney.py: Handle version-ranged dependencies a bit > smarter > > Avoid creating two dependency clauses for dependencies emulating a > "version range" a la: > > Depends: pkg-a (>= 2), pkg-a (<< 3~) > > Previously this would create two clauses a la: > > - (pkg-a, 2, arch), (pkg-a, 3, arch) > - (pkg-a, 1, arch), (pkg-a, 2, arch) > > However, it is plain to see that only (pkg-a, 2, arch) is a valid > solution and the other options are just noise. This patch makes > Britney merge these two claues into a single clause containing exactly > (pkg-a, 1, arch).
I think you mean (pkg-a, 2, arch) here, right? > >From 922d3fc01cbee8417ec7bad5bb566ad7e1709819 Mon Sep 17 00:00:00 2001 > From: Niels Thykier <ni...@thykier.net> > Date: Sat, 19 Jul 2014 20:05:23 +0200 > Subject: [PATCH 06/11] installability: Exploit equvialency to reduce choices > > For some cases, like aspell-dictionary, a number of packages can > satisfy the dependency (e.g. all aspell-*). In the particular > example, most (all?) of the aspell-* look so similar to the extend "extent" not "extend". > >From 8e9e26245141e47ae229c886c4c48a805428764a Mon Sep 17 00:00:00 2001 > From: Niels Thykier <ni...@thykier.net> > Date: Thu, 24 Jul 2014 23:52:50 +0200 > Subject: [PATCH 09/11] britney.py: Refactor doop_source > > Rename local variables and avoid repeated chained lookups. In > particular, avoid confusing cases like: > > [...] > version = binaries[parch][0][binary][VERSION] > > [...] > binaries[parch][0][binary] = self.binaries[item.suite][parch][0][binary] > version = binaries[parch][0][binary][VERSION] > > Where "version" here will refer to two different versions. The former > the version from testing of a hijacked binary and the latter the > version from the source suite (despite the look up using the "testing" > table, due to the testing copy being updated). > > Notable renamings: > * binaries => packages_t (a.k.a. self.binaries['testing']) > * binaries[parch][0] => binaries_t_a > * binaries[parch][1] => provides_t_a > * Similar naming used for "item.suite" instead of "testing" > > The naming is based on the following logic: > * self.binaries from "packages" files > (by this logic, it ought to be "self.packages", but thats for Missing apostrophe in "that's". Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org> -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140729035530.gc18...@freya.jamessan.com
