Your message dated Mon, 17 Nov 2014 13:58:59 +0000
with message-id <9c7ee39e054a4267ebf4f94bf409f...@mail.adsl.funky-badger.org>
and subject line Re: Bug#769877: unblock: lightdm/1.10.3-3
has caused the Debian Bug report #769877,
regarding unblock: lightdm/1.10.3-3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
769877: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769877
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
Please unblock package lightdm
Hi,
a fix for #749243 (sev. normal) which went in lightdm 1.10.2-3 actually
caused a regression in lightdm, where user choices were not correctly
remembered. This was reported as #767359 (sev. normal) and fixed by
reverting the changes made in 1.10.2-3 and making sure the folder was
created.
I've let this version sit in unstable for a bit to check that didn't
introduce new regression, and it seems ok.
Relevant changelog entries follows and full debdiff is attached:
lightdm (1.10.3-3) unstable; urgency=medium
* debian/patches:
- 06_change-user-dirs edited, don't use /var/lib/lightdm directly (it
seems to confuse lightdm and break .dmrc saving) but use
/var/lib/lightdm/data and create it at runtime. closes: #767359
-- Yves-Alexis Perez <cor...@debian.org> Tue, 04 Nov 2014 21:58:15 +0100
unblock lightdm/1.10.3-3
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (450,
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru lightdm-1.10.3/debian/changelog lightdm-1.10.3/debian/changelog
--- lightdm-1.10.3/debian/changelog 2014-10-24 14:32:08.000000000 +0200
+++ lightdm-1.10.3/debian/changelog 2014-11-04 21:58:17.000000000 +0100
@@ -1,3 +1,12 @@
+lightdm (1.10.3-3) unstable; urgency=medium
+
+ * debian/patches:
+ - 06_change-user-dirs edited, don't use /var/lib/lightdm directly (it
+ seems to confuse lightdm and break .dmrc saving) but use
+ /var/lib/lightdm/data and create it at runtime. closes: #767359
+
+ -- Yves-Alexis Perez <cor...@debian.org> Tue, 04 Nov 2014 21:58:15 +0100
+
lightdm (1.10.3-2) unstable; urgency=medium
* debian/patches:
diff -Nru lightdm-1.10.3/debian/patches/06_change-user-dirs.patch lightdm-1.10.3/debian/patches/06_change-user-dirs.patch
--- lightdm-1.10.3/debian/patches/06_change-user-dirs.patch 2014-10-08 22:51:17.000000000 +0200
+++ lightdm-1.10.3/debian/patches/06_change-user-dirs.patch 2014-10-31 21:10:46.000000000 +0100
@@ -5,7 +5,7 @@
-I"$(top_srcdir)/common" \
-DSBIN_DIR=\"$(sbindir)\" \
- -DUSERS_DIR=\"$(localstatedir)/lib/lightdm-data\" \
-+ -DUSERS_DIR=\"$(localstatedir)/lib/lightdm\" \
++ -DUSERS_DIR=\"$(localstatedir)/lib/lightdm/data\" \
-DLOG_DIR=\"$(localstatedir)/log/lightdm\" \
-DRUN_DIR=\"$(localstatedir)/run/lightdm\" \
-DCACHE_DIR=\"$(localstatedir)/cache/lightdm\" \
@@ -16,7 +16,18 @@
-I"$(top_srcdir)/common" \
-DSBIN_DIR=\"$(sbindir)\" \
- -DUSERS_DIR=\"$(localstatedir)/lib/lightdm-data\" \
-+ -DUSERS_DIR=\"$(localstatedir)/lib/lightdm\" \
++ -DUSERS_DIR=\"$(localstatedir)/lib/lightdm/data\" \
-DLOG_DIR=\"$(localstatedir)/log/lightdm\" \
-DRUN_DIR=\"$(localstatedir)/run/lightdm\" \
-DCACHE_DIR=\"$(localstatedir)/cache/lightdm\" \
+--- a/src/shared-data-manager.c
++++ b/src/shared-data-manager.c
+@@ -99,7 +99,7 @@ shared_data_manager_ensure_user_dir (Sha
+
+ g_debug ("Creating shared data directory %s", path);
+
+- result = g_file_make_directory (file, NULL, &error);
++ result = g_file_make_directory_with_parents (file, NULL, &error);
+ if (error)
+ {
+ if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_EXISTS))
--- End Message ---
--- Begin Message ---
On 2014-11-17 9:21, Yves-Alexis Perez wrote:
a fix for #749243 (sev. normal) which went in lightdm 1.10.2-3 actually
caused a regression in lightdm, where user choices were not correctly
remembered. This was reported as #767359 (sev. normal) and fixed by
reverting the changes made in 1.10.2-3 and making sure the folder was
created.
I've let this version sit in unstable for a bit to check that didn't
introduce new regression, and it seems ok.
Unblocked, thanks.
Regards,
Adam
--- End Message ---