Your message dated Fri, 27 Feb 2015 19:48:07 +0100
with message-id <20150227184807.gf30...@ugent.be>
and subject line Re: Bug#779290: unblock: dvd+rw-tools/7.1-11
has caused the Debian Bug report #779290,
regarding unblock: dvd+rw-tools/7.1-11
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
779290: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779290
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

Please unblock package dvd+rw-tools (not yet uploaded, I'm asking
for approval before uploading).

The current dvd+rw-tools will fail right at the end when burning
a bluray BD-R disc with the error message "CLOSE SESSION failed".

This affects all frontends that use growisofs (like k3b and more,
there are recommendations on the net to install cdrecord from third
party sources to workaround the issue).

The relevant bug and fix is described in #713016. Its a one-line
diff that is used in fedora since June 2013 [1]. I think it would
be good if we could release with a fix for this bug as bluray seem
to be quite common and we should support it with free tools.

The full diff is attached.

Thanks for your consideration,
 Michael


unblock dvd+rw-tools/7.1-11

[1] 
http://pkgs.fedoraproject.org/cgit/dvd+rw-tools.git/commit/?id=545689bfb2a04cb642b48a8495024e23545363a4

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
diff -Nru dvd+rw-tools-7.1/debian/changelog dvd+rw-tools-7.1/debian/changelog
--- dvd+rw-tools-7.1/debian/changelog   2011-03-07 10:48:42.000000000 -0500
+++ dvd+rw-tools-7.1/debian/changelog   2015-02-26 10:40:30.000000000 -0500
@@ -1,3 +1,12 @@
+dvd+rw-tools (7.1-11) unstable; urgency=medium
+
+  * debian/patches/10-blue-ray-bug713016.patch:
+    - apply patch from Thomas Schmitt to fix in session closing
+      on blue ray (closes: #713016), LP: #1113679
+  * added myself to uploaders
+
+ -- Michael Vogt <m...@debian.org>  Thu, 19 Feb 2015 12:34:23 +0100
+
 dvd+rw-tools (7.1-10) unstable; urgency=low
 
   * Add patch to fix grammar in manpage. Closes: #607605.
diff -Nru dvd+rw-tools-7.1/debian/control dvd+rw-tools-7.1/debian/control
--- dvd+rw-tools-7.1/debian/control     2011-03-07 08:53:35.000000000 -0500
+++ dvd+rw-tools-7.1/debian/control     2015-02-26 10:41:23.000000000 -0500
@@ -3,7 +3,8 @@
 Priority: optional
 Maintainer: Optical Media Tools Team 
<pkg-opt-media-t...@lists.alioth.debian.org>
 Uploaders: TANIGUCHI Takaki <tak...@debian.org>,
-          Rogério Brito <rbr...@ime.usp.br>
+          Rogério Brito <rbr...@ime.usp.br,
+           Michael Vogt <m...@debian.org>
 DM-Upload-Allowed: yes
 Build-Depends: debhelper (>= 7),
               libcam-dev [kfreebsd-i386 kfreebsd-amd64],
diff -Nru dvd+rw-tools-7.1/debian/patches/10-blue-ray-bug713016.patch 
dvd+rw-tools-7.1/debian/patches/10-blue-ray-bug713016.patch
--- dvd+rw-tools-7.1/debian/patches/10-blue-ray-bug713016.patch 1969-12-31 
19:00:00.000000000 -0500
+++ dvd+rw-tools-7.1/debian/patches/10-blue-ray-bug713016.patch 2015-02-26 
10:39:24.000000000 -0500
@@ -0,0 +1,17 @@
+## Description: Fix spurious "CLOSE SESSION failed" on BD-R
+## Origin/Author: Thomas Schmitt <scdbac...@gmx.net>
+## Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713016
+Index: dvd+rw-tools-7.1/growisofs_mmc.cpp
+===================================================================
+--- dvd+rw-tools-7.1.orig/growisofs_mmc.cpp
++++ dvd+rw-tools-7.1/growisofs_mmc.cpp
+@@ -756,6 +757,9 @@ static void bd_r_format (Scsi_Command &c
+ 
+     wait_for_unit (cmd);
+ 
++    // debian bug #713016
++    bdr_plus_pow = 1;
++
+     cmd[0] = 0x35;    // FLUSH CACHE
+     cmd[9] = 0;
+     cmd.transport();
diff -Nru dvd+rw-tools-7.1/debian/patches/series 
dvd+rw-tools-7.1/debian/patches/series
--- dvd+rw-tools-7.1/debian/patches/series      2011-03-07 10:45:34.000000000 
-0500
+++ dvd+rw-tools-7.1/debian/patches/series      2015-02-26 10:39:24.000000000 
-0500
@@ -8,3 +8,4 @@
 08-includes.patch
 09-wctomb.patch
 ignore_pseudo_overwrite.patch
+10-blue-ray-bug713016.patch

--- End Message ---
--- Begin Message ---
Hi,

On Fri, Feb 27, 2015 at 08:47:52AM +0100, Michael Vogt wrote:
> Sure, I just did the upload for this.

Unblocked.

> Its a minimal diff to improve the chances that this makes it into the
> release.

Thanks for that!

> > The changes that I have are on the master branch of
> > 
> >    https://github.com/rbrito/pkg-dvd-rw-tools
> > 
> > but they have some modernization and/or cosmetic changes (well, changing the
> > packaging to compat 9 of debhelper enables hardening of the package, which
> > isn't enabled in the version in unstable---if that is OK for testing, then I
> > guess that the work of uploading stuff is almost complete and only a quick
> > last review would suffice).
> 
> Thanks for this! I like that, especially that the hardening is
> enabled now. For the next upload I guess :) (unless the release team
> grants a exception for the benefit of having the hardening).

That kind of change is not appropriate at this time of the freeze, so it
should be delayed till after the release.

Cheers,

Ivo

--- End Message ---

Reply via email to