Package: release.debian.org Severity: normal Tags: jessie User: release.debian....@packages.debian.org Usertags: pu
Dear Release Team, I'd like to do a stable update for gnome-shell-extension-weather, which is a GNOME Shell extension which displays weather forecasts (and is pulled by the gnome metapackage, though not activated by default). The applet relies on a web service (openweather.org) which recently changed its policy: users must now generate an API key to fetch forecast data (previously the API key was optional). As a consequence, the extension no longer works unless the user has added an API key in the configuration settings. But nothing is there to inform the user that he now has to do so. The extension therefore appears to be broken (see bug #801979). The attached debdiff implements a warning notification if the API key is missing, in order to guide the user towards the action to be implemented. Best, -- .''`. Sébastien Villemot : :' : Debian Developer `. `' http://sebastien.villemot.name `- GPG Key: 4096R/381A7594
diff -Nru gnome-shell-extension-weather-0~20140924.git7e28508/debian/changelog gnome-shell-extension-weather-0~20140924.git7e28508/debian/changelog --- gnome-shell-extension-weather-0~20140924.git7e28508/debian/changelog 2014-09-24 20:20:37.000000000 +0200 +++ gnome-shell-extension-weather-0~20140924.git7e28508/debian/changelog 2015-10-24 22:21:39.000000000 +0200 @@ -1,3 +1,11 @@ +gnome-shell-extension-weather (0~20140924.git7e28508-1+deb8u1) jessie; urgency=medium + + * d/p/missing-api-key.patch: new patch. Displays a warning if API key + has not been supplied by the user, since querying openweather.org no + longer works without such a key. (Closes: #801979) + + -- Sébastien Villemot <sebast...@debian.org> Fri, 23 Oct 2015 21:26:28 +0000 + gnome-shell-extension-weather (0~20140924.git7e28508-1) unstable; urgency=medium * New upstream snapshot. diff -Nru gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/missing-api-key.patch gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/missing-api-key.patch --- gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/missing-api-key.patch 1970-01-01 01:00:00.000000000 +0100 +++ gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/missing-api-key.patch 2015-10-24 22:17:45.000000000 +0200 @@ -0,0 +1,20 @@ +Description: Add notification if API key is missing + The API is now mandatory for using openweather.org. +Origin: backport, https://github.com/jenslody/gnome-shell-extension-openweather/commit/f9f97dcaaa0b7d51a4b4193ba3802b3d0ba10441 +Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801979 +Reviewed-by: Sébastien Villemot <sebast...@debian.org> +Last-Update: 2015-10-24 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +--- a/src/extension.js ++++ b/src/extension.js +@@ -138,6 +138,9 @@ const OpenweatherMenuButton = new Lang.C + // Load settings + this.loadConfig(); + ++ if (this._appid.toString().trim() == '') ++ Main.notify("Openweather", _("Openweathermap.org does not work without an api-key.\nPlease register at http://openweathermap.org/appid and paste your personal key into the preferences dialog.")); ++ + // Label + this._weatherInfo = new St.Label({ + y_align: Clutter.ActorAlign.CENTER, diff -Nru gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/series gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/series --- gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/series 2014-05-09 21:42:23.000000000 +0200 +++ gnome-shell-extension-weather-0~20140924.git7e28508/debian/patches/series 2015-10-23 23:25:11.000000000 +0200 @@ -0,0 +1 @@ +missing-api-key.patch
signature.asc
Description: PGP signature