Hi,

On 18-04-04 23:58:32, Hleb Valoshka wrote:
> On 4/4/18, Georg Faerber <ge...@riseup.net> wrote:
> > ruby-gettext-setup FTBFS now, with errors like
> >
> > /usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb:50:in `gsub':
> > invalid byte sequence in US-ASCII (ArgumentError)
> >
> > See #894829 for details.
> >
> 
> /usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb is UTF-8 file,
> it contains japanese letters (こんにちは世界), of course these letters
> can't be processed in C locale.
> 
> So you either patch it to remove UTF-8 characters or run tests in
> C.UTF-8.

Please go ahead and feel free to fix the package; I failed to do so
yesterday, but I've to admit, I didn't spent much time. Also, my local
setup is currently broken.

> I don't think that the last ruby-gettext update introduced a
> regression as in the previous version it had a terrible insecure
> parser for ruby strings:
> begin; s = eval(s); rescue Exception; end

I don't get the relation between "no regression" and "previous version
had a terrible insecure parser".

> Now it has a proper one.

No doubt -- thanks for your work and the upload.

The point I was trying to make: Let's work together, better (in the
future). For example: Before uploading such a change, communicate about
it especially if it introduces a breaking change.

Cheers,
Georg

Attachment: signature.asc
Description: Digital signature

Reply via email to