On Wed, Sep 27, 2017 at 01:10:16AM +0100, D Haley wrote:
> Dear Sébastien,
> 
> I have corrected d/control & d/copyright, as well as updating to compat
> 10. This has been pushed as f513233d7. gbp import-orig --pristine-tar
> has been used to import the upstream tarball, and have also been pushed.

Thanks. However something is wrong with the upstream branch: it includes a
debian/ subdirectory.

Please fix the upstream branch (possibly by writing history): it should contain
exactly the files included in upstream tarball. Don't forget to update the
pristine-tar branch accordingly as needed. One should be able to recreate from
the git a tarball byte-to-byte identical to the upstream tarball. You can check
that it works correctly by moving away your local copy of upstream tarball,
running "gbp buildpackage -S", and verify that the tarball it created is the
same as upstream tarball.

Also please document all your changes in debian/changelog (at least adding the
bump to debhelper compat 10).

> A quick question : Unless I'm mistaken, it seems that VCS-Git and
> VCS-Browser are the same (and this is reflected in debian-science
> policy). Is there a link to explain why we are duplicate this, so I can
> understand this a bit better? I'm assuming its to do with enforcing
> https transport?

The two URLs are not exactly the same. Vcs-Browser has /cgit/ while Vcs-Git has
/git/.

Note that the Vcs-Git URL in your debian/control file is wrong, you should
replace /cgit/ by /git/.

The Debian Science policy is also outdated on this issue, we should fix it.

Thanks,

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org

Attachment: signature.asc
Description: PGP signature

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to