Hi Richard, On Thu, 2026-04-23 at 21:57 +0100, Richard Lewis wrote: > Good evening, i'm looking for a sponsor for chkrootkit 0.59-1, this is in git > at > > https://salsa.debian.org/pkg-security-team/chkrootkit/ > > > Notes: > - It does have a debian/changelog -- I know some people advise to > only make the changelog with 'gbp dch' immediately before uploading, but > i like to start with that and edit it a bit
From my perspective it is reasonable to draft the changelog using 'gbp dch' and possibly do some editing on top. Only, the release field should be kept 'UNRELEASED' in salsa.d.o until after the actual upload. > - The many debian patches are simplified a lot -- might be easier to read the > result than the diffs > This should make future changes simpler > I continue to suggest upstream incorporates most of these patches, some of > which have been in debian > for decades... As upstream does not run a public bug tracker, I propose to copy the emails you sent/send to them to some kind of public archive for documentation purposes, perhaps dedicated wishlist bugs against src:checkrootkit can be used or simply the team mailing list. After that the resulting URLs could be used with the Forwarded: field of the patch headers. > - the salsa pipeline would pass but it looks like it hits a bug in the > lintian job > (lintian is clean locally) > (reported: https://salsa.debian.org/salsa-ci-team/pipeline/-/work_items/562) It might be worth trying out whether setting the release to 'UNRELEASED' fixes the issue. > - the debian/watch file stopped working - which i see Sven already reported as > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1116646 > I upgraded debian/watch to v5 -- but i dont think this will work any better It does not, indeed. > - (I believe the autopkgtests for the previous version will no longer pass > due to changes in salsa: the > version in 0.59-1 should work around this) > - I believe it will now compile on the hurd, although i am not 100% sure of > this > (this is just to make > https://buildd.debian.org/status/package.php?p=chkrootkit clean) It still does not compile on the hurd. In one of my previous reviews you should find a description of how you can test this locally. Currently the build fails due to chkdirs.c: At top level: chkdirs.c:77:6: error: conflicting types for ‘statfs’; have ‘long int(const char *, struct statfs *)’ 77 | long statfs(const char *path, struct statfs *buf){ | ^~~~~~ > > And (deep breath): i'd be interested in working towards an eventual DM status > for this > package, should that be possible. In addition to what I wrote in my previous reply, I recommend you list yourself as another uploader in d/control documenting your intend to maintain chkrootkit on a long-term basis. Overall you work looks sound, however, you might want to fix this tiny typo: debian/tests/test-chkrootkit:88: echo "unount: $x" I suggest you do these two changes before I sponsor the package. Best, Sven -- GPG Fingerprint 3DF5 E8AA 43FC 9FDF D086 F195 ADF5 0EDA F8AD D585
signature.asc
Description: This is a digitally signed message part
