Sven Geuer <[email protected]> writes: > On Thu, 2026-04-23 at 21:57 +0100, Richard Lewis wrote:
>> https://salsa.debian.org/pkg-security-team/chkrootkit/ >> >> >> Notes: >> - It does have a debian/changelog -- I know some people advise to >> only make the changelog with 'gbp dch' immediately before uploading, but >> i like to start with that and edit it a bit > > From my perspective it is reasonable to draft the changelog using 'gbp > dch' and possibly do some editing on top. Only, the release field > should be kept 'UNRELEASED' in salsa.d.o until after the actual upload. OK: this is now done > As upstream does not run a public bug tracker, I propose to copy the > emails you sent/send to them to some kind of public archive for > documentation purposes, perhaps dedicated wishlist bugs against > src:checkrootkit can be used or simply the team mailing list. After > that the resulting URLs could be used with the Forwarded: field of the > patch headers. Good idea, i will set this up > >> - the salsa pipeline would pass but it looks like it hits a bug in the >> lintian job >> (lintian is clean locally) >> (reported: >> https://salsa.debian.org/salsa-ci-team/pipeline/-/work_items/562) > > It might be worth trying out whether setting the release to > 'UNRELEASED' fixes the issue. > Unfortunately not. (I think the pipeline is mangling the latest version in debian/changelog, but not making a similar change in debian/NEWS.) >> - I believe it will now compile on the hurd, although i am not 100% sure of >> this >> (this is just to make >> https://buildd.debian.org/status/package.php?p=chkrootkit clean) > > It still does not compile on the hurd. In one of my previous reviews > you should find a description of how you can test this locally. > Currently the build fails due to > > chkdirs.c: At top level: > chkdirs.c:77:6: error: conflicting types for ‘statfs’; have ‘long > int(const char *, struct statfs *)’ > 77 | long statfs(const char *path, struct statfs *buf){ > | ^~~~~~ (bah! i will try fix this again - soon) >> And (deep breath): i'd be interested in working towards an eventual DM >> status for this >> package, should that be possible. > > In addition to what I wrote in my previous reply, I recommend you list > yourself as another uploader in d/control documenting your intend to > maintain chkrootkit on a long-term basis. > > Overall you work looks sound, however, you might want to fix this tiny > typo: > > debian/tests/test-chkrootkit:88: echo "unount: $x" > > I suggest you do these two changes before I sponsor the package. Done (with one more commit as exim added a new provider of sendmail) (nb, i also removed '* Team upload' from debian/changelog as lintian otherwise complains 'W: chkrootkit source: unnecessary-team-upload [debian/changelog:1]' due to the new uploaders. Thanks again
