Hi, Thanks a lot for your careful review. A lot of apologise for my delay.
On Fri, Aug 03, 2018 at 03:53:41AM -0400, Alexandre Viau wrote: > Hello, > > On 2018-08-02 05:28 AM, Jongmin Kim wrote: > > Hello, Go team. > > > > I prepared packaging for https://github.com/tcnksm/go-gitconfig . > > It is present at: > > > > https://salsa.debian.org/go-team/packages/golang-github-tcnksm-go-gitconfig > > . > > Thank you for your work. > > I have some comments: > > d/rules: > - Why do you skip tests? Please add a comment when you do something > like this. This is especially intriguing because the tests pass on my > machine. I will add a comment when I skip, exclude, and do something like this. Thank you! We applied a patch instead of skipping the test. 'go-gitconfig' did a test which is not fully isolated from testing environment. It fails when it runs on git repo with its local config including 'user.name' and/or 'user.email'. In my case, those config were auto-genereted by 'dh-make-golang' which made me got a fail. Felix Lechner (who has an ITP on 'git-lab' which depends on this package) suggests me and sent me a patch for isolating the testing environment. The patch makes the test creating and using the temporary git repo instead of using the real, both for global config (~/.gitconfig) and local config (.git/config). He also sent a PR to the upstream repo [1] for fixing this problem. When it fixed, we will remove the patch and update the package. > > d/control: > - the short description is "use gitconfig values in Go" > Maybe "gitconfig values in Go". The "use" looks a big odd here. > > - I am not sure I would link to the upstream-hosted documentation here > because it could fall out of sync with Debian. I made a change with your suggestions. Thank you! I tried to make the repository to keep the upstream's commit history, instead of using 'pristine-tar'. In result, I created again a new repository in my namespace: https://salsa.debian.org/jmkim-guest/golang-github-tcnksm-go-gitconfig Would you please consider to use this for packaging, instead of using our team's repo? Thank you! [1] https://github.com/tcnksm/go-gitconfig/pull/8 -- Jongmin Kim OpenPGP key located at https://jmkim-pgp.github.io/keys/pubkey.D39D8D29BAF36DF8.Jongmin_Kim.asc OpenPGP fingerprint: 012E 4A06 79E1 4EFC DAAE 9472 D39D 8D29 BAF3 6DF8
signature.asc
Description: PGP signature
