Review: Needs Information This is a nice patch. Thank you so much for the contribution!
Can you explain the rationale? I mean, clearly, the default automatic algorithm doesn't work for you. But what is your use case, how does it fail? I have heretofore viewed the decision of when to make a full backup as 'something the user doesn't need to worry about (i.e. an internal algorithmic decision)'. When Deja Dup makes a full backup isn't really a user visible feature, so I'm not sure it needs to be a user-controllable preference. It's just something we do to help protect against corrupted backups. We don't really expose what a full backup means. I don't think the target audience would understand the trade offs between security of the backup and space unless it was explained in the UI. And I'm not sure we want to be in the business of explaining it. I could just be being silly though. Could you explain yourself a bit more? Minor problems with the patch: * Add a copyright statement to each file you non-trivially touch * Add yourself to AUTHORS (in the main 'Files: *' stanza) * Add yourself to deja-dup/MainWindow.vala's about dialog in alphabetical order Medium problems with the patch: * Add the new file to po/POTFILES.in and update the pot file (make update-pot or cd po; make deja-dup.pot) * Add an entry in data/deja-dup.schemas.in * Use similar wording to ConfigPeriod.vala: "Weekly", "Monthly", "Every three months", "Every %d days". We already have some of that translated, and it's more consistent. * Make the default "Automatic" (either by redefining 0 as automatic or better yet, setting a default of -1 in the schema) * The "Each month" setting is actually set to two months (28*2). -- https://code.edge.launchpad.net/~tobedeprez/deja-dup/deja-dup/+merge/16803 Your team Déjà Dup Maintainers is subscribed to branch lp:deja-dup. _______________________________________________ Mailing list: https://launchpad.net/~deja-dup-team Post to : [email protected] Unsubscribe : https://launchpad.net/~deja-dup-team More help : https://help.launchpad.net/ListHelp
