minor comment inline (otherwise ACK):
On 14/11/11 17:09, mfoj...@redhat.com wrote:
> From: Michal Fojtik <mfoj...@redhat.com>
>
> +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
> +# License for the specific language governing permissions and limitations
> +# under the License.
> +
> +class CIMI::Model::MachineConfiguration < CIMI::Model::Base
> +
> + scalar :memory
> + text :cpu
> +
> + array :disk do
> + scalar :capacity
also, :format and :attachment_point
> + end
> +
> + array :operations do
> + scalar :rel, :href
> + end
> +end
> diff --git a/server/spec/cimi/data/machine_configuration.json
> b/server/spec/cimi/data/machine_configuration.json
> new file mode 100644
> index 0000000..8864340
> --- /dev/null
> +++ b/server/spec/cimi/data/machine_configuration.json
> @@ -0,0 +1,17 @@
> +{
> + "uri": "http://cimi.example.org/machine_configurations/1";,
> + "name": "MachineConfiguration1",
> + "description": "Example MachineConfiguration One",
> + "created": "2011-11-14",
> + "cpu": "2",
> + "memory" : { "quantity": "1", "units": "gigabyte" },
> + "disks" : [
> + { "capacity": { "quantity": "1", "units": "terabyte", "format": "ext4",
> "attachmentPoint": "/" } }
> + ],
I think this will be:
"disks" : [
{ "capacity": { "quantity": "1", "units": "terabyte"}},
{"format": "ext4"}, {"attachmentPoint": "/" }
> + ],
> + "properties": [ { "name": "architectore", "value" : "i386" } ],
> + "operations": [
> + { "rel": "edit",
> + "href": "http://cimi.example.org/machine_images/1/edit"; },
> + { "rel": "delete",
> + "href": "http://cimi.example.org/machine_images/1/delete"; }]
> +}
> diff --git a/server/spec/cimi/data/machine_configuration.xml
> b/server/spec/cimi/data/machine_configuration.xml
> new file mode 100644
> index 0000000..788a185
> --- /dev/null
> +++ b/server/spec/cimi/data/machine_configuration.xml
> @@ -0,0 +1,14 @@
> +<MachineConfiguration xmlns="http://www.dmtf.org/cimi";>
> + <uri>http://cimi.example.org/machine_configurations/1</uri>
> + <name>MachineConfiguration1</name>
> + <description>Example MachineConfiguration One</description>
> + <created>2011-11-14</created>
> + <property name="architecture">i386</property>
> + <cpu>2</cpu>
> + <memory quantity="1" units="gigabyte"/>
> + <disk>
> + <capacity quantity="1" units="terabyte" format="ext4"
> attachmentPoint="/"/>
> + </disk>
again, I think its:
<disk>
<capacity quantity="1" units="terabyte"/>
<format="ext4"/>
<attachmentPoint="/"/>
</disk>
I should raise a mantis issue since I can't see this in any of the
examples, even though :format and :attachmentPoint are mandatory.
