minor comment inline: On 14/11/11 17:09, mfoj...@redhat.com wrote: > From: Michal Fojtik <mfoj...@redhat.com> > diff --git a/server/lib/cimi/model/base.rb b/server/lib/cimi/model/base.rb > index 0ef2b27..de6529b 100644 > --- a/server/lib/cimi/model/base.rb > +++ b/server/lib/cimi/model/base.rb > @@ -163,7 +163,7 @@ class CIMI::Model::Base > text :uri, :name, :description, :created > > # FIXME: this doesn't match with JSON > - array :properties, :content => :value do > - scalar :key > + array :property, :content => :value do > + scalar :name
This was changed to :key and I think it makes more sense for it to be :properties since it's meant to be a 'set of properties'. JSON: "properties": { "key": string, + }, ? XML: <property key="xs:string"> xs:string </property> * otherwise ACK