You mean the statement that the work was really boring? ;-) ;-) Ok, I've recovered it now. And yes, I'd love to see a better way to create mock objects. Right now the MockRepository (and some unit tests) need to create these objects, so -- so long as we can find a nice way to do that [preferably under src/test, and perhaps not shipped w/ releases], I'm definitely +1 to see the statics removed the core classes.
BTW: Sorry if I was crabby, I'm frustrated that I'm not getting this back into shape quicker/sooner. I know we are close, I know we have a good foundation, I think it is just hidden behind some confusion. I like your Javadoc comments, and I'll try to add to those. I'm hoping we are 'clean' within no more than a week, and we -- total group -- understand the codebase we have, and how it works. That is the main short term goal, IMHO. Also, I think it is key that we get green and stay green -- not having working unit tests means we don't know when we delete/break something important. For me (in Eclipse) I couldn't run the Ant unit tests, but I think I now can. I'll work to get the tests working, and then we can rest easier that we can hack w/o breaking (undetected). regards, Adam ----- Original Message ----- From: "Markus M. May" <[EMAIL PROTECTED]> To: "Depot Development" <[EMAIL PROTECTED]> Sent: Thursday, July 29, 2004 7:55 AM Subject: Re: Deleting stuff > Hmm, this was the testing stuff I was working on currently. Sorry for the > delay :-( > I do prefer the creation of the testing objects in the test class. And I > definitly agree on your statement in the first mail :-) > > > Greetz > > Markus > > > Ok, I see that viewcvs can help me find old code. I can go borrow it > > again. > > > > Markus, the if the getTextXXXX stuff is ugly I'm game to change it to a > > better set of Mock objects (I just couldn't think of a better way at the > > time). I'll add them back (for now) but then happily work w/ folks to > > clean > > them out of important classes and get them into better places. > > > > regards > > > > Adam > > ----- Original Message ----- > > From: "Adam R. B. Jack" <[EMAIL PROTECTED]> > > To: "Depot Dev" <[EMAIL PROTECTED]> > > Sent: Thursday, July 29, 2004 7:40 AM > > Subject: Deleting stuff > > > > > > > Folks > > > > > > >From now on can we discuss something before deleting it? I know we had > > some > > > baggage, but I don't think we have much/any left (in Updater, and > > Version > > > I'd like to keep as my problem please). > > > > > > Right now I am trying to get some key unit tests working and I am > > finding > > > that the main Artifact*.getTestXXXX static helper methods appear > > missing. > > I > > > spent a lot of really boring time adding those, and the prospect of > > doing > > it > > > again is seriously disheartening. (SVN is, IMHO, a pain in the rear to > > > recover from, and I don't plan on trying to guess old version numbers to > > > copy over and manually merge from). > > > > > > Please, although I doubt anything more is remaining to be snipped, > > please > > > let's discuss twice, cut once. > > > > > > regards > > > > > > Adam > > > -- > > > Experience the Unwired Enterprise: > > > http://www.sybase.com/unwiredenterprise > > > Try Sybase: http://www.try.sybase.com > >
