ResultColumnList and ColumnDescriptor were modified by Mamta's patch, I remember reviewing them...
David Satheesh Bandaram wrote: > Great job getting this done. This is indeed a very useful Enhancement to > Derby. > > Looking briefly at the attached patch, some comments: > > 1. I think syntax for GENERATED BY DEFAULT needs to include the *BY*, > according to SQL standard. > 2. One of the main uses of this new clause is for importing data into > IDENTITY columns. I would like to see some tests that import data > into tables created with the new identity option. Import code > actually uses bulkInsert option, so it would be good to test this > code path too. I can help, if needed, on these tests. Before > commiting the patch, it would be good to add more tests in general. > 3. I couldn't fully apply the patch. Had issues with two files, > ResultColumnList and ColumnDescriptor. I think these files might > have been updated since you started working on the patch. It would > be good if you can merge up to the latest version. > > Again, great to see the patch. > > Satheesh > > TomohitoNakayama wrote: > >> Hello. >> >> I think coding for solution-1 of DERBY-167 has done. >> I attach patch file to this mail for others to confirm it. >> >> Relating test , autoincrement and columnDefaults , was passed. >> >> >> However, In derbyall test , I found many errors which seems not caused >> by my modification. >> Errors seems to be devided three kind ... >> 1:Error of parameterMapping. I don't know what is parameter Mapping mean, >> but file names told so. >> 2:Error of i18n. It seems that English message was generated though >> test assume Spanish. >> 3:Error of derbynetclientmats. >> >> I uploaded $TEST_DIR/derbyall_fail.txt and $TEST_DIR/derbyall_diff.txt >> to my web directory, >> because size was too large. >> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_fail.txt >> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_diff.txt >> >> Something is going on ...? >> >> >> Best regards. >> >> >> /* >> >> Tomohito Nakayama >> [EMAIL PROTECTED] >> [EMAIL PROTECTED] >> >> Naka >> http://www5.ocn.ne.jp/~tomohito/TopPage.html >> >> */ >> >>------------------------------------------------------------------------ >> >>No virus found in this outgoing message. >>Checked by AVG Anti-Virus. >>Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04 >> >>
