[ 
http://issues.apache.org/jira/browse/DERBY-398?page=comments#action_12314801 ] 

Daniel John Debrunner commented on DERBY-398:
---------------------------------------------

I think for all the new files you've added (<test>_app.properties) to exclude 
tests for J2ME  Foundation, the correct contents should be as below. Changes are

1) Comment that the tests are being excluded for J2ME/Foundation, not j9. J9 is 
a VM implementation by IBM,
whereas these tests are being excluded due to generic J2ME/Foundation 
restricitions.
(And there is a separate runwithj9 flag that does exclude tests specifically 
for the IBM J9 vm, but that is
not what you need here)

2)  Even better would be a comment saying why they are excluded, e.g. test 
requires BigDecimal

3) The usedefaults flag means the contents of the default_app.properties file 
is picked up, which is what would happen before adding a new 
<test>_app.properties. This means those properties are not in multiple places 
now, so that if the default_app.properties need to be changed, it is not 
required to change all these other properties files.

Can you re-submit the patch?

-------------------------------------------------------------------------

#Exclude for J2ME/Foundation - test requires ???
runwithfoundation=false

usedefaults=true



> Exclude tests for J2ME/CDC/Foundation platform
> ----------------------------------------------
>
>          Key: DERBY-398
>          URL: http://issues.apache.org/jira/browse/DERBY-398
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Reporter: Deepa Remesh
>     Assignee: Deepa Remesh
>  Attachments: derby-398.diff, derby-398.status, derbyall_report.txt
>
> Exclude tests which use DriverManager, Driver or BigDecimal classes which are 
> not in J2ME or JSR169. Ensure that derbyall can be run successfully in 
> J2ME/CDC/Foundation platform using the JDBC Optional Package for 
> CDC/Foundation Profile (JSR169).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to