David W. Van Couvering wrote:

> I like to start by applying a patch to the revision level that the patch
> was built with.  That way I can make very sure I applied things
> correctly -- I can diff the output of svn status and svn diff with what
> the contributor provided.  This is especially important when the
> contribution includes files that are added (especially new empty files
> like empty test master files), which I actually have to add by hand.
> 
> Once that looks good, I do an svn update with no -r option to update the
> tree to the head of the trunk.  If at this point I get errors, then,
> yes, I would complain to the contributor, but I want to make sure I
> applied the patch correctly first.
> 
> Maybe that's not how everyone does it, but that's how I like to do it,
> so that's why I was suggesting the revision number.  I can also do it by
> date, but the revision number is more accurate.

Ok sounds fine, isn't the svn revision in the svn diff output though?

Dan.

Reply via email to