[
https://issues.apache.org/jira/browse/DERBY-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862060#comment-13862060
]
Kathey Marsden commented on DERBY-4805:
---------------------------------------
Hi Mamta,
I think your patch looks good to me except with regard to settling on the new
max size for RDBNAM and making adjustments. I think the total max ddm length
for the PKGNAMCSN will need to be 32767 so you will need to calculate the max
size for the other fields in the PKGNAMCSN (or other DDM objects that contain
RDBNAM).
There is a condition in NetStatementReply which I think needs to be adjusted to
the new length as well.
} else if ((ddmLength >= 71) && (ddmLength <= 781)) {
// this is the new SCLDTA format.
Backing out the current 255 length for RDBNAM, I think that means that the
other fields take 526 bytes so the new limit would be 32,241. We could make it
32,000 just to use a round number.
For the test it would be good to test the new limit which I think you can do
with.
writeScalarPaddedBytes RDBNAM "thisNeedsToBeNoMoreThan255CharactersLong" #####
(where #### is the new limit)
It would be good also to have a test right at the limit.
I would appreciate another pair of eyes on this patch. It has been a long time
for me since I have done any protocol work.
> Increase the length of the RDBNAM field in the DRDA implementation
> ------------------------------------------------------------------
>
> Key: DERBY-4805
> URL: https://issues.apache.org/jira/browse/DERBY-4805
> Project: Derby
> Issue Type: Improvement
> Components: Network Client, Network Server
> Affects Versions: 10.7.1.1
> Reporter: Tiago R. Espinha
> Assignee: Mamta A. Satoor
> Labels: derby_triage10_9
> Attachments: DERBY_4805_diff_patch1.txt
>
>
> Currently, whenever the client driver is used, there is a limit of 255 bytes
> for the database name. This is defined by the DRDA spec and there has been a
> discussion on the list [1]/[2] as to whether this limit should be raised due
> to the introduction of the new ACR that allows for UTF-8 characters.
> UTF-8 characters can take up to four bytes and this reduces the limit in
> characters dramatically.
> This should be an easy change as there is a codepoint that defines this limit.
> [1] did not work but [2] did
> [1] - http://old.nabble.com/Database-name-length-tt29691419.html
> [2]http://apache-database.10148.n7.nabble.com/Database-name-length-td33182.html
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
