[
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528836#comment-16528836
]
Rick Hillegas commented on DERBY-6945:
--------------------------------------
Attaching derby-6945-41-ac-cleanupProductJavadoc.diff. This patch removes an
unused, empty class and tweaks some header comments so that module-aware
javadoc can be built on the entire product codeline. Module-aware javadoc for
the test classes will become possible in a later patch. Another patch may be
necessary in order to build module-aware javadoc for the public API. After
that, the actual javadoc targets can be changed. Tests passed cleanly for me
with this patch.
The following command builds clean (warning free, error free) module-aware
javadoc for the product classes:
{noformat}
javadoc -d ./build/javadoc \
-Xdoclint:none \
--module-source-path $derbyRoot/java:$derbyRoot/generated/java \
--module-path
$derbyRoot/classes/stubs/felix:$derbyRoot/tools/java/geronimo-spec-servlet-2.4-rc4.jar:$derbyRoot/tools/java/json_simple-1.1.jar:$derbyRoot/tools/java/lucene-analyzers-common.jar:$derbyRoot/tools/java/lucene-core.jar:$derbyRoot/tools/java/lucene-queryparser.jar
\
--show-module-contents all \
--show-packages all \
--module
org.apache.derby.commons,org.apache.derby.engine,org.apache.derby.client,org.apache.derby.server,org.apache.derby.tools,org.apache.derby.optionaltools,org.apache.derby.runner
{noformat}
Touches the following files:
{noformat}
-------------------------------
D
java/org.apache.derby.engine/org/apache/derby/impl/sql/GenericClassInfo.java
Remove an unreferenced and empty class (no source code at all) which
confused the module-aware javadoc command.
-------------------------------
M
java/org.apache.derby.client/org/apache/derby/client/ClientDataSourceFactory.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientDatabaseMetaData.java
M
java/org.apache.derby.client/org/apache/derby/client/am/FailedProperties40.java
M java/org.apache.derby.client/org/apache/derby/client/am/Sqlca.java
M
java/org.apache.derby.client/org/apache/derby/client/am/stmtcache/package.html
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/StandardException.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/EngineType.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/Property.java
M
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/FailedProperties40.java
M
java/org.apache.derby.engine/org/apache/derby/iapi/sql/conn/LanguageConnectionContext.java
M
java/org.apache.derby.engine/org/apache/derby/iapi/types/BooleanDataValue.java
M
java/org.apache.derby.engine/org/apache/derby/impl/sql/execute/rts/RealSetOpResultSetStatistics.java
M
java/org.apache.derby.engine/org/apache/derby/impl/store/access/btree/index/package.html
M java/org.apache.derby.engine/org/apache/derby/mbeans/Version.java
M java/org.apache.derby.engine/org/apache/derby/mbeans/VersionMBean.java
Tweak header references to classes which are outside the visibility of
certain source files. The module-aware javadoc command was raising
warnings on these references.
{noformat}
> Re-package Derby as a collection of jigsaw modules
> --------------------------------------------------
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.13.1.2
> Reporter: Rick Hillegas
> Priority: Major
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff,
> derby-6945-02-ab-newDerbySharedJar.diff,
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff,
> derby-6945-04-aa-moveRunClass.diff,
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff,
> derby-6945-06-aa-removeOtherSharedDuplicates.diff,
> derby-6945-07-aa-net_client_overlap.diff,
> derby-6945-08-aa-move_shared_iapi_under_shared.diff,
> derby-6945-08-ab-move_shared_iapi_under_shared.diff,
> derby-6945-08-ad-move_shared_iapi_under_shared.diff,
> derby-6945-09-ab-moveInternalDriver.diff, derby-6945-10-aa-moveDriver42.diff,
> derby-6945-11-ab-moveAutoloadedDriver.diff,
> derby-6945-12-ab-moveClientDataSourceInterface.diff,
> derby-6945-13-aa-create-ClientAutoloadedDriver.diff,
> derby-6945-14-aa-moveMoreEmbeddedClassesOutOfPublicAPI.diff,
> derby-6945-15-aa-moveMoreClientClassesOutOfPublicAPI.diff,
> derby-6945-16-aa-consolidatePublicAPI.diff,
> derby-6945-17-aa-resealPackagesIn-derbyshared.diff,
> derby-6945-18-aa-resealLocalizationPackage.diff,
> derby-6945-19-ad-movePublicAPIintoToolsJar.diff,
> derby-6945-20-aa-removeClasslister.diff,
> derby-6945-21-aa-simplifyBuildScripts.diff,
> derby-6945-21-ab-simplifyBuildScripts.diff,
> derby-6945-22-ad-isolateClassesByArtifact.diff,
> derby-6945-22-ae-isolateClassesByArtifact.diff,
> derby-6945-22-af-isolateClassesByArtifact.diff,
> derby-6945-23-aa-upgradeToAnt_1.10.2.diff,
> derby-6945-24-aa-fixNativeAuthenticationServiceTest.diff,
> derby-6945-25-ab-moduleDescriptors.diff,
> derby-6945-26-aa-packagePrivateTests.diff,
> derby-6945-27-aa-adjustModulesForTests.diff,
> derby-6945-28-aa-testingModuleDescriptor.diff,
> derby-6945-29-aa-disable-SimpleApp-test.diff,
> derby-6945-30-ab-move-clientmessages-toolsmessages.diff,
> derby-6945-31-aa-clientmessages-ResourceBundleProvider.diff,
> derby-6945-32-aa-messageLookupCleanup.diff,
> derby-6945-33-ab-moveLocalizations.diff,
> derby-6945-34-aa-licenseHeaders.diff,
> derby-6945-35-aa-removeSpuriousCharacter.diff,
> derby-6945-36-aa-moduleDescriptorsForLocaleJars.diff,
> derby-6945-38-aa-javadocCleanup.diff, derby-6945-39-aa-javadocCleanup.diff,
> derby-6945-40-aa-generatedSource-dirNames.diff,
> derby-6945-41-ac-cleanupProductJavadoc.diff,
> derby-6945-XX-moveDataSourceFactories, jdeps.out.tar, weirdAnt.out
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider
> re-packaging Derby as a set of jigsaw modules. This would result in a
> different set of release artifacts. This might be a good opportunity to
> address the Tomcat artifactory issues raised by issue DERBY-6944.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
