[
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528921#comment-16528921
]
Rick Hillegas commented on DERBY-6945:
--------------------------------------
Attaching derby-6945-43-aa-cleanupPublicAPIforJavadoc.diff. This patch makes a
couple more packages public to the world so that classes in those packages will
appear in the module-aware javadoc for the public API--and so that they really
are public. I will run tests.
The following command builds clean (warning free, error free) module-aware
javadoc for the public API:
{noformat}
javadoc -d ./build/javadoc \
-Xdoclint:none \
--module-source-path $derbyRoot/java:$derbyRoot/generated/java \
--module-path
$derbyRoot/classes/stubs/felix:$derbyRoot/tools/java/geronimo-spec-servlet-2.4-rc4.jar:$derbyRoot/tools/java/junit.jar:$derbyRoot/tools/java/json_simple-1.1.jar:$derbyRoot/tools/java/lucene-analyzers-common.jar:$derbyRoot/tools/java/lucene-core.jar:$derbyRoot/tools/java/lucene-queryparser.jar
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/agg/Aggregator.java \
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/AwareVTI.java \
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/BasicClientConnectionPoolDataSource40.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/BasicClientDataSource40.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/BasicClientXADataSource40.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/BasicEmbeddedConnectionPoolDataSource40.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/BasicEmbeddedDataSource40.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/BasicEmbeddedXADataSource40.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/mbeans/CacheManagerMBean.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/ClientConnectionPoolDataSource.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/ClientDataSource.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/ClientDriver.java \
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/ClientXADataSource.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/tools/dblook.java \
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/EmbeddedConnectionPoolDataSource.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/EmbeddedDataSource.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/EmbeddedDriver.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/jdbc/EmbeddedXADataSource.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/ForeignTableVTI.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/ForwardingVTI.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/tools/ij.java \
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/mbeans/JDBCMBean.java \
$derbyRoot/java/org.apache.derby.optionaltools/org/apache/derby/optional/api/LuceneIndexDescriptor.java
\
$derbyRoot/java/org.apache.derby.optionaltools/org/apache/derby/optional/api/LuceneUtils.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/mbeans/Management.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/mbeans/ManagementMBean.java
\
$derbyRoot/java/org.apache.derby.server/org/apache/derby/drda/NetServlet.java
\
$derbyRoot/java/org.apache.derby.server/org/apache/derby/drda/NetworkServerControl.java
\
$derbyRoot/java/org.apache.derby.server/org/apache/derby/mbeans/drda/NetworkServerMBean.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/RestrictedVTI.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/Restriction.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/catalog/SequencePreallocator.java
\
$derbyRoot/java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonUtils.java
\
$derbyRoot/java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonVTI.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/StringColumnVTI.java
\
$derbyRoot/java/org.apache.derby.tools/org/apache/derby/tools/sysinfo.java \
$derbyRoot/java/org.apache.derby.commons/org/apache/derby/shared/common/security/SystemPermission.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/authentication/UserAuthenticator.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/mbeans/VersionMBean.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/VTIContext.java \
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/VTICosting.java \
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/VTIEnvironment.java
\
$derbyRoot/java/org.apache.derby.engine/org/apache/derby/vti/VTITemplate.java
{noformat}
Touches the following files:
{noformat}
M java/org.apache.derby.commons/module-info.java
M java/org.apache.derby.server/module-info.java
Adjust these module descriptors so that a couple more classes in the
public API are really public.
{noformat}
> Re-package Derby as a collection of jigsaw modules
> --------------------------------------------------
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.13.1.2
> Reporter: Rick Hillegas
> Priority: Major
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff,
> derby-6945-02-ab-newDerbySharedJar.diff,
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff,
> derby-6945-04-aa-moveRunClass.diff,
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff,
> derby-6945-06-aa-removeOtherSharedDuplicates.diff,
> derby-6945-07-aa-net_client_overlap.diff,
> derby-6945-08-aa-move_shared_iapi_under_shared.diff,
> derby-6945-08-ab-move_shared_iapi_under_shared.diff,
> derby-6945-08-ad-move_shared_iapi_under_shared.diff,
> derby-6945-09-ab-moveInternalDriver.diff, derby-6945-10-aa-moveDriver42.diff,
> derby-6945-11-ab-moveAutoloadedDriver.diff,
> derby-6945-12-ab-moveClientDataSourceInterface.diff,
> derby-6945-13-aa-create-ClientAutoloadedDriver.diff,
> derby-6945-14-aa-moveMoreEmbeddedClassesOutOfPublicAPI.diff,
> derby-6945-15-aa-moveMoreClientClassesOutOfPublicAPI.diff,
> derby-6945-16-aa-consolidatePublicAPI.diff,
> derby-6945-17-aa-resealPackagesIn-derbyshared.diff,
> derby-6945-18-aa-resealLocalizationPackage.diff,
> derby-6945-19-ad-movePublicAPIintoToolsJar.diff,
> derby-6945-20-aa-removeClasslister.diff,
> derby-6945-21-aa-simplifyBuildScripts.diff,
> derby-6945-21-ab-simplifyBuildScripts.diff,
> derby-6945-22-ad-isolateClassesByArtifact.diff,
> derby-6945-22-ae-isolateClassesByArtifact.diff,
> derby-6945-22-af-isolateClassesByArtifact.diff,
> derby-6945-23-aa-upgradeToAnt_1.10.2.diff,
> derby-6945-24-aa-fixNativeAuthenticationServiceTest.diff,
> derby-6945-25-ab-moduleDescriptors.diff,
> derby-6945-26-aa-packagePrivateTests.diff,
> derby-6945-27-aa-adjustModulesForTests.diff,
> derby-6945-28-aa-testingModuleDescriptor.diff,
> derby-6945-29-aa-disable-SimpleApp-test.diff,
> derby-6945-30-ab-move-clientmessages-toolsmessages.diff,
> derby-6945-31-aa-clientmessages-ResourceBundleProvider.diff,
> derby-6945-32-aa-messageLookupCleanup.diff,
> derby-6945-33-ab-moveLocalizations.diff,
> derby-6945-34-aa-licenseHeaders.diff,
> derby-6945-35-aa-removeSpuriousCharacter.diff,
> derby-6945-36-aa-moduleDescriptorsForLocaleJars.diff,
> derby-6945-38-aa-javadocCleanup.diff, derby-6945-39-aa-javadocCleanup.diff,
> derby-6945-40-aa-generatedSource-dirNames.diff,
> derby-6945-41-ac-cleanupProductJavadoc.diff,
> derby-6945-42-aa-cleanupTestJavadoc.diff,
> derby-6945-43-aa-cleanupPublicAPIforJavadoc.diff,
> derby-6945-XX-moveDataSourceFactories, jdeps.out.tar, weirdAnt.out
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider
> re-packaging Derby as a set of jigsaw modules. This would result in a
> different set of release artifacts. This might be a good opportunity to
> address the Tomcat artifactory issues raised by issue DERBY-6944.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
