[ http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12363759 ]
David Van Couvering commented on DERBY-819: ------------------------------------------- Hi, Anurag. I'm looking at the latest patch. This actually looks quite good, but I do have some formatting comments. I know these may seem trivial, but readability of code is quite important for long-term maintainability - From my previous review, I mentioned that it would be great if the lines did not exceed 80 characters. I didn't see your response to that, and they're still wrapping around (see your diffs for Util.java as an example). What's your position on this? - In InternalDriver.java, your first addition is indented way, way over to the right. Any reason for that? - Ah, your test looks much cleaner :) If you can fix the two formatting issues, I'll be happy to do a test build and testrun and check this in. David > Provide JDBC4 SQLException subclasses support in Embedded driver > ---------------------------------------------------------------- > > Key: DERBY-819 > URL: http://issues.apache.org/jira/browse/DERBY-819 > Project: Derby > Type: Sub-task > Components: JDBC > Environment: all > Reporter: Anurag Shekhar > Assignee: Anurag Shekhar > Priority: Minor > Attachments: derby-819.diff, stat.out > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
