Daniel John Debrunner wrote:
[snip]
I believe these were driven (according to the patch notes) because of the bug in 983. Ie. leave Util.notImplemented() as its old implementation so the client could (incorrectly) continue to call it, and modify the engine to use the new mechanism. Ie. the client wouldn't be using the new InternalDriver could, which it shouldn't. Now once, 983 is fixed, embedded can continue to call Util.notImplemented() and have Util.notImplemented() call InternalDriver.getSQLExceptionFactory().notImplemented(); I.e. continue using the shorthand method to reduce footprint.
I see what you are saying, thanks.
I think 983 should be committed first. I'll look at the patch for 819, and hopefully raise my veto, maybe it's ok to leave all the calls to InternalDriver.getSQLExceptionFactory().notImplemented() and someone can modify them to use a shorthand method later if they have the itch.
OK. I actually have that itch and (if I'm still around and not on paternity leave) I may fix that as part of my checkin for 819
David
begin:vcard fn:David W Van Couvering n:Van Couvering;David W org:Sun Microsystems, Inc.;Database Technology Group email;internet:[EMAIL PROTECTED] title:Senior Staff Software Engineer tel;work:510-550-6819 tel;cell:510-684-7281 x-mozilla-html:TRUE version:2.1 end:vcard
